Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for num_traits::identities. #158

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

virtualritz
Copy link
Contributor

@virtualritz virtualritz commented Mar 20, 2023

This is for #157.

  • The impls are in src/vec/num_traits.rs.
  • This is behind a resp. feature flag documented in src/lib.rs and README.md.
  • I took the liberty to reorder the features alphabetically (except f64 & int as these are probably what people look for most).
  • clippy clean.

I noticed three serde tests are failing when cargo test --all-features is ran but they did so before my changes:

test impl_serde::mat_serde_tests::mat2 ... FAILED
test impl_serde::mat_serde_tests::mat3 ... FAILED
test impl_serde::mat_serde_tests::mat4 ... FAILED

@virtualritz
Copy link
Contributor Author

I forgot, I didn't add tests as these additions so far are just wrappers around exisiting functions.

@fu5ha
Copy link
Owner

fu5ha commented Mar 20, 2023

Great, thanks! Only thing is could you add a note to the changelog? :D

@virtualritz
Copy link
Contributor Author

Done!

@fu5ha fu5ha merged commit 9ed7c9a into fu5ha:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants