Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve CLI issues on Mac #10

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

ffMathy
Copy link
Contributor

@ffMathy ffMathy commented Apr 5, 2023

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

On Mac, the include path check did not work for me.

Context: https://stackoverflow.com/questions/6398196/detect-if-called-through-require-or-directly-by-command-line

I followed the above changes.

Test

  1. Clone this repo. The following commands are then run in that repo folder.
  2. Run yarn install.
  3. Run npm link.
  4. Run npm run watch to build and watch for changes.
  5. Start another project. The following commands are then run in that project.
  6. Install @ftrack/ts-schema-generator into the project from NPM.
  7. Run npm link @ftrack/ts-schema-generator to symbiotically link the project's ts-schema-generator to the repo's folder.
  8. Execute the generator via the following scripts command: "ftrack:schema": "ftrack-ts-schema-generator ./ftrack schema.ts"

@ffMathy ffMathy requested a review from a team as a code owner April 5, 2023 14:20
.yarnrc.yml Outdated Show resolved Hide resolved
source/index.ts Outdated Show resolved Hide resolved
@ffMathy
Copy link
Contributor Author

ffMathy commented Apr 6, 2023

By the way, this is the pull request I was describing: ftrackhq/ftrack-javascript#97

@gismya
Copy link
Contributor

gismya commented Apr 6, 2023

I removed the export from the generate function and ran the prettier formatting

@ffMathy
Copy link
Contributor Author

ffMathy commented Apr 6, 2023

Ah yes. I always forget that 😂 thanks! 🙏

@gismya gismya merged commit b2f57ae into ftrackhq:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants