feat: Add disconnect method to event hub #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this! ❤️ |
ffMathy
approved these changes
May 22, 2024
jimmycallin
reviewed
May 22, 2024
|
|
||
| test("Disconnecting should disconnect the socket", () => { | ||
| eventHub.disconnect(); | ||
| expect(disconnectCalled).toBe(true); |
There was a problem hiding this comment.
Suggested change
| expect(disconnectCalled).toBe(true); | |
| expect(eventHub._socketIo.disconnect).toHaveBeenCalled(); |
think you can do something like this, a bit more idiomatic
There was a problem hiding this comment.
No, I'm setting _socketIo to undefined as part of the disconnect.
There was a problem hiding this comment.
ah, I guess you then could do this:
const disconnectFn = vi.fn()
...
disconnect: disconnectFn,
...
expect(disconnectFn).toHaveBeenCalled()
but we can go with this approach as well
jimmycallin
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PR to address #238. Adds a disconnect method to the event hub
Test