fix: Catch preflight errors on file upload #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaas
reviewed
Mar 6, 2024
source/uploader.ts
Outdated
| if (this.onError) { | ||
| this.onError(error as Error); | ||
| } | ||
| return; |
There was a problem hiding this comment.
We should probably retain the previous behavior where start throw:ed if the preflight failed.
There was a problem hiding this comment.
Suggested change
| return; | |
| if (this.onError) { | |
| this.onError(error as Error); | |
| } | |
| throw error; |
When I throw an error like above instead of return, I receive this error message instead of notifyError. Is there any way to prevent this?
lucaas
approved these changes
Mar 8, 2024
mertkirbuga
deleted the
backlog/attackers-can-upload-any-malicious-file-to-notes-attachments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FT-6c8dae2f-08cf-4ed6-a119-d15c8d538fd0
Changes
Includes changes related with catching errors on file upload on preflight phase.
Please also follow up https://github.com/ftrackhq/ftrack-server/pull/750
Test