fix: publishReply has incorrect Event in reply

[gismya]

• I have added automatic tests where applicable
• The PR title is suitable as a release note
• The PR contains a description of what has been changed
• The description contains manual test instructions

Changes

The shape of the data in the Event sent by publishReply was incorrect since the TypeScript refactoring. target and inReplyToEvent ended up inside Event._data.data instead of Event._data This broke the ability to register actions. Another issue, where the source was incorrectly written over in publish was also fixed.

I also added tests for the Event creation, and a test to ensure the shape of the event data is correct in publishReply

Test

After linking the repo to an ftrack instance, you can create a dummy action with

let session = ftrackSpark.getSession?.() ?? FT.spark.getSharedSession();

session.eventHub.subscribe("topic=ftrack.action.discover", () => {
  return {
    items: [
      {
        label: "Test action",
        description: "Description",
        actionIdentifier: "test-action-id",
      },
    ],
  };
});

session.eventHub.subscribe("topic=ftrack.action.launch", () => {
  return {
    items: [
      {
        label: "My String",
        type: "text",
        value: "no string",
        name: "my_string",
      },
      {
        label: "My String2",
        type: "text",
        value: "no string2",
        name: "my_string2",
      },
      {
        label: "My Date",
        type: "date",
        name: "my_date",
        value: "2022-09-16",
      },
      {
        label: "My Number",
        type: "number",
        name: "my_number",
        empty_text: "Type a number here...",
      },
      {
        value: "## This is a label. ##",
        type: "label",
      },
      {
        label: "Enter your text",
        name: "my_textarea",
        value: "some text",
        type: "textarea",
      },
      {
        label: "My Boolean",
        name: "my_boolean",
        value: true,
        type: "boolean",
      },
      {
        value: "This field is hidden",
        name: "my_hidden",
        type: "hidden",
      },
      {
        label: "My Enum",
        type: "enumerator",
        name: "my_enumerator",
        data: [
          {
            label: "Option 1",
            value: "opt1",
          },
          {
            label: "Option 2",
            value: "opt2",
          },
        ],
      },
    ],
  };
});

Make sure it shows up in actions.

[lucaas]

Added some minor comments/questions.

Looking at the code, it is very confusing with everything on the event stored as Event._data. I am not sure why, but it would be better to just have them defined as as e.g. Event.source and remove the useless getData method.

[gismya]

@lucaas Thanks for the comments. Everything has been addressed.

regarding the structure of Event, I agree it's confusing. Something we might address in the future.

[lucaas]

Nice job!