fix: Revert "Replace socket.io-client" #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmycallin
approved these changes
May 26, 2023
gismya
added a commit
that referenced
this pull request
Sep 14, 2023
* Revert "fix: Revert "Replace socket.io-client" (#111)" This reverts commit ca25de7. * Fix cors issue on fetchSessionId * Include credentials in fetch * Another one * Improved reconnect behaviour * Add an online listener to reconnect before reconnectTimeout in case browser online event triggers. * fixed tests and improved error handling * Refetch sessionId every connection attempt and bind this to eventlistener callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves FT-714936d4-8f5c-41b6-bbc6-6e484f97dedf
Changes
This reverts PR #99 and PR #108 - since we were seeing some issues with this in a browser context. This will keep main releasable in the meantime.
We will setup a new PR with the new client and can target any fixes there.
Test