Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARI protocol #329

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

WhitWaldo
Copy link

@WhitWaldo WhitWaldo commented Jan 21, 2025

Description

This PR implements the latest working draft ARI protocol into the client. There are two core changes I've made to the client:

  1. Directory object is updated to reflect the new renewalInfo endpoint
  2. A new method is introduced on the AcmeContext that, given the bytes comprising a previously issued PFX certificate and its password will produce a properly formed (tests pending) ARI Certificate ID. This can either be generated as needed or persisted to facilitate easier lookups without pulling the certificate itself.
    2a) At regular intervals following a certificate issuance the ARI Certificate ID is appended to the end of the renewalInfo endpoint from the directory. When the certificate is eligible for renewal, a suggested renewal window will be provided returning a range of suggested timestamps to perform the renewal. The renewal should be scheduled at some point in this interval.
    2b) When the renewal is triggered, as part of creating the new Order, there's a new overload for NewOrder that's been added that will accept the ARI Certificate ID value, populating the Replaces property and confirming this is an ARI-style renewal and not subject to standard renewal rate limitations, assuming the other requirements are met.

I'm having some issues getting the tests running and validated because I just don't have the older .NET frameworks installed and several of the packages are quite old (getting warnings as errors), so submitting this as a draft right now with an intent to wrap it up within the next few days.

Checklist

  • All tests are passing
  • New tests were created to address changes in pr (and tests are passing)
  • Updated README and/or documentation, if necessary

Thanks for contributing!

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant