Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format via black and add installation of dev deps to contributing docs #464

Merged
merged 1 commit into from
Apr 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ You can create a virtual environment using ``conda`` and install the development
```bash
$ conda create -n adlfs-dev python=3.8
$ conda activate adlfs-dev
$ pip install -r requirements/latest.txt
$ pip install -r requirements/latest.txt -r requirements.dev
```

You can run tests from the main directory as follows:
Expand Down
9 changes: 6 additions & 3 deletions adlfs/tests/test_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,7 @@ def test_rm_recursive(mock_delete_blob, storage):
mock.ANY, "root/c"
), "The directory deletion should be the last call"


@pytest.mark.filterwarnings("error")
def test_rm_recursive2(storage):
fs = AzureBlobFileSystem(
Expand All @@ -771,14 +772,16 @@ def test_rm_recursive2(storage):
async def test_rm_recursive_call_order(storage, mocker):
from azure.storage.blob.aio import ContainerClient

delete_blob_mock = mocker.patch.object(ContainerClient, "delete_blob", return_value=None)
delete_blob_mock = mocker.patch.object(
ContainerClient, "delete_blob", return_value=None
)
fs = AzureBlobFileSystem(
account_name=storage.account_name, connection_string=CONN_STR
)

container_name = "data"
file_paths = [
"root/a",
"root/a",
"root/a/file.txt",
"root/a1",
"root/a1/file1.txt",
Expand All @@ -793,7 +796,7 @@ async def test_rm_recursive_call_order(storage, mocker):
"root/e+f",
"root/e+f/file1.txt",
"root/e+f/file2.txt",
"root/rfile.txt"
"root/rfile.txt",
]
await fs._rm_files(container_name=container_name, file_paths=file_paths)
last_deleted_paths = [call.args[0] for call in delete_blob_mock.call_args_list[-7:]]
Expand Down
Loading