feat: use presigned urls for s3 #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonostendorf
added
enhancement
TitusKirch
requested changes
Aug 22, 2024
This was referenced Aug 22, 2024
Merged
TitusKirch
requested changes
Aug 22, 2024
simonostendorf
commented
Aug 27, 2024
| @@ -4,7 +4,6 @@ declare namespace App.Models { | |||
| created_at: string /* Date */ | null; | |||
| updated_at: string /* Date */ | null; | |||
| event_id: number; | |||
| course_id: number | null; | |||
There was a problem hiding this comment.
after regenerating the types, the course_id was removed from the groups model. Currently I dont know why this happened.
There was a problem hiding this comment.
Is available as course?: Course | null;.
TitusKirch
approved these changes
Aug 27, 2024
TobiasGrether
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #624