Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly detect University IP ranges #490

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Properly detect University IP ranges #490

merged 4 commits into from
Feb 13, 2024

Conversation

dasGoogle
Copy link
Contributor

@dasGoogle dasGoogle commented Feb 13, 2024 •
edited
Loading

This PR also requires some changes to the configuration. See the example env file for details.

Closes #331

@dasGoogle dasGoogle linked an issue Feb 13, 2024 that may be closed by this pull request
Support multiple anonymous IP ranges #331
Closed
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 7886610653

Details

  • -1 of 8 (87.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 74.508%
Changes Missing Coverage Covered Lines Changed/Added Lines %
myhpi/core/middleware.py 6 7 85.71%
Totals Coverage Status
Change from base Build 7886409057: 0.03%
Covered Lines: 1286
Relevant Lines: 1726
💛 - Coveralls

@dasGoogle dasGoogle merged commit d7c56bb into main Feb 13, 2024
8 checks passed
@dasGoogle dasGoogle deleted the 331-support-multiple-anonymous-ip-ranges branch February 13, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple anonymous IP ranges
2 participants
@dasGoogle @jeriox