Workaround for NoPartialFuncs bug #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added regression test for NoPartialFunctions rule for weird case encountered when linting FSharpLint.Console/Program.fs.
Why is this info not in the commit msg? |
knocte
reviewed
Jan 16, 2024
Workaround for bug in FSharp.Compiler.Services that sometimes results in "FSharp.Compiler.Service cannot yet return this kind of pattern match at ..." exception (see ``Regression found when parsing Console/Program_fs`` test case). Issue in F# github repo: [1]. There is a merged PR that should address this bug: [2]. But at the moment latest FSharp.Compiler.Services on nuget (43.8.101) doesn't include that fix. [1] dotnet/fsharp#8854 [2] dotnet/fsharp#16121
webwarrior-ws
force-pushed
the
nopartialfuncs-regression
branch
from
b7e4340 to
106be3f
Compare
updated commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for bug in FSharp.Compiler.Services that sometimes results in "FSharp.Compiler.Service cannot yet return this kind of pattern match at ..." exception.
Example code that produces the bug:
Issue in F# github repo: dotnet/fsharp#8854
There is a merged PR that should address this bug: dotnet/fsharp#16121
But at the moment latest FSharp.Compiler.Services on nuget (43.8.101) doesn't include that fix.