Simplify SelfCheck #679
Merged
Simplify SelfCheck #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to leave test projects out of the SelfCheck really.
This way it is more readable, more consistent across all tests, and lets you add more content to the snippet without causing git-blame noise.
There was a mix of 2-space and 4-space indentation in the tests, now it is consistent to 4-space. Also, in some cases such as the one starting with "module Foo", there was no need for indentation (there would be a need if the snippet started with "module Foo =" tho).
* If a let declaration doesn't have any params, it isn't really a function; so let's add some () to fix them. * Funcs alone can't live inside a namespace, but rather a module. * For loops can't live inside a module, they need to be inside a function. * A function's last line cannot be a let declaration. * The public tuple snippet didn't need a main wrapper func. * No need for [<EntryPoint>] attributes in tests. * Better to use `module` than `open`/`namespace`, especially in tests that don't need the latter. * etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting the whole solution instead of two specific projects.