-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from .NET5 to .NET6 #655
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET5 is out of support, and .NET6 is an LTS version.
With `dotnet tool update paket --version 7.2.1`; because the previous CI's err message was: ``` Run dotnet fake build -t Build Extracted Paket.Restore.targets to: /home/runner/work/FSharpLint/FSharpLint/.paket/Paket.Restore.targets (Can be disabled with PAKET_SKIP_RESTORE_TARGETS=true) There was a problem while setting up the environment: -> Extracting platforms from path 'net6.0' failed, a newer Paket version might support it, otherwise please open an issue for a missing platform handler. Hint: If you just upgraded the fake-runner you can try to remove the .fake directory and try again. Error: Process completed with exit code 1. ```
Update Paket restrictions by editing paket.dependencies changing frameworks to net6.0. And two additional things: 1) change netstandard2.0 to net6.0 as a workaround[2] to a FAKE bug[1]. 2) use 'strategy: min' to avoid dependencies be upgraded to versions that require net8.0 (e.g. Microsoft.Build.Framework 15.1.0.0 depending on FSharp.Core 8.0.0.0). [1] fsprojects/FAKE#2619 [2] fsprojects/FAKE#2619 (comment)
With `dotnet paket install --keep-patch`.
With `dotnet tool update fake-cli`, because maybe an old fake-cli is the one pinning the old version of paket?
With `dotnet paket update --group build`, because we were getting: ``` Script is not valid: /home/runner/work/FSharpLint/FSharpLint/build.fsx (82,60)-(82,66): Error FS0039: The value, namespace, type or module 'SemVer' is not defined. /home/runner/work/FSharpLint/FSharpLint/build.fsx (84,28)-(84,33): Error FS0039: The record label 'Patch' is not defined. Hint: If you have updated your dependencies you might need to run 'paket install' or delete '/home/runner/work/FSharpLint/FSharpLint/build.fsx.lock' for fake to pick them up. Hint: If this doesn't help but you are sure this should work try to clean your nuget cache and delete the .fake directory. If this helps please report this problem to Paket. Hint: Could not find a version in your paket.dependencies file, consider adding 'version 7.1.5' at the top of your dependencies file (/home/runner/work/FSharpLint/FSharpLint/paket.dependencies). Read fsprojects/FAKE#2193 for details. Hint: The fake-runner has not been updated for at least 6 months. Please consider upgrading to get latest bugfixes, improved suggestions and F# features. Error: Process completed with exit code 1. ``` This fixes the build, but the tests are not passing yet.
In order to avoid this problem when running the tests: ``` sing "CheckForImplicitPackageReferenceOverrides" task from assembly "/usr/share/dotnet/sdk/6.0.417/Sdks/Microsoft.NET.Sdk/targets/../tools/net6.0/Microsoft.NET.Build.Tasks.dll". Task "CheckForImplicitPackageReferenceOverrides" Done executing task "CheckForImplicitPackageReferenceOverrides". Done building target "CheckForImplicitPackageReferenceOverrides" in project "FSharpLint.FunctionalTest.TestedProject.MultiTarget.fsproj". Target "ApplyImplicitVersions" in file "/usr/share/dotnet/sdk/6.0.417/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.DefaultItems.Shared.targets" from project "/home/runner/work/FSharpLint/FSharpLint/tests/FSharpLint.FunctionalTest.TestedProject/FSharpLint.FunctionalTest.TestedProject.MultiTarget/FSharpLint.FunctionalTest.TestedProject.MultiTarget.fsproj" (target "ProcessFrameworkReferences" depends on it): Using "ApplyImplicitVersions" task from assembly "/usr/share/dotnet/sdk/6.0.417/Sdks/Microsoft.NET.Sdk/targets/../tools/net6.0/Microsoft.NET.Build.Tasks.dll". Task "ApplyImplicitVersions" Done executing task "ApplyImplicitVersions". Done building target "ApplyImplicitVersions" in project "FSharpLint.FunctionalTest.TestedProject.MultiTarget.fsproj". Target "ProcessFrameworkReferences" in file "/usr/share/dotnet/sdk/6.0.417/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets" from project "/home/runner/work/FSharpLint/FSharpLint/tests/FSharpLint.FunctionalTest.TestedProject/FSharpLint.FunctionalTest.TestedProject.MultiTarget/FSharpLint.FunctionalTest.TestedProject.MultiTarget.fsproj" (target "ResolvePackageAssets" depends on it): Using "CheckForDuplicateFrameworkReferences" task from assembly "/usr/share/dotnet/sdk/6.0.417/Sdks/Microsoft.NET.Sdk/targets/../tools/net6.0/Microsoft.NET.Build.Tasks.dll". Task "CheckForDuplicateFrameworkReferences" Done executing task "CheckForDuplicateFrameworkReferences". Using "ProcessFrameworkReferences" task from assembly "/usr/share/dotnet/sdk/6.0.417/Sdks/Microsoft.NET.Sdk/targets/../tools/net6.0/Microsoft.NET.Build.Tasks.dll". Task "ProcessFrameworkReferences" The "ProcessFrameworkReferences" task failed unexpectedly. System.IO.FileLoadException: Could not load file or assembly 'NuGet.Frameworks, Version=6.3.3.3, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Could not find or load a specific file. (0x80131621) File name: 'NuGet.Frameworks, Version=6.3.3.3, Culture=neutral, PublicKeyToken=31bf3856ad364e35' ---> System.IO.FileLoadException: Could not load file or assembly 'NuGet.Frameworks, Version=6.3.3.3, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. at System.Runtime.Loader.AssemblyLoadContext.LoadFromPath(IntPtr ptrNativeAssemblyLoadContext, String ilPath, String niPath, ObjectHandleOnStack retAssembly) at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath) at Microsoft.Build.Shared.MSBuildLoadContext.Load(AssemblyName assemblyName) at System.Runtime.Loader.AssemblyLoadContext.ResolveUsingLoad(AssemblyName assemblyName) at System.Runtime.Loader.AssemblyLoadContext.Resolve(IntPtr gchManagedAssemblyLoadContext, AssemblyName assemblyName) at System.Linq.Enumerable.WhereEnumerableIterator`1.ToList() at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source) at Microsoft.NET.Build.Tasks.ProcessFrameworkReferences.ExecuteCore() at Microsoft.NET.Build.Tasks.TaskBase.Execute() at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) Done executing task "ProcessFrameworkReferences" -- FAILED. ```
Issuing a `paket install --keep-patch` after the previous paket.deps change, and when this failed because of a conflict, I removed the conflicting dep from paket.lock and run it again. This is the log of my trial&errors: ``` % dotnet paket install --keep-patch Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c Skipping resolver for group Build since it is already up-to-date Skipping resolver for group Docs since it is already up-to-date Resolving dependency graph... Total time taken: 5 seconds Paket failed with -> There was a version conflict during package resolution. Conflict detected: - Dependencies file requested package Microsoft.NET.Test.Sdk: 17.7.2 - Dependencies file requested package Microsoft.NET.Test.Sdk: >= 16.10 < 16.10.1 Please try to relax some conditions or resolve the conflict manually (see http://fsprojects.github.io/Paket/nuget-dependencies.html#Use-exactly-this-version-constraint). knocte@knocte-macbook FSharpLintMASTERCLEAN % git gui knocte@knocte-macbook FSharpLintMASTERCLEAN % dotnet paket install --keep-patch knocte@knocte-macbook FSharpLintMASTERCLEAN % nano paket.lock knocte@knocte-macbook FSharpLintMASTERCLEAN % nano paket.lock knocte@knocte-macbook FSharpLintMASTERCLEAN % dotnet paket install --keep-patch Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c Skipping resolver for group Build since it is already up-to-date Skipping resolver for group Docs since it is already up-to-date Resolving dependency graph... Total time taken: 10 seconds Paket failed with -> There was a version conflict during package resolution. Conflict detected: - Dependencies file requested package Microsoft.CodeCoverage: >= 16.10 < 16.10.1 - Microsoft.NET.Test.Sdk 17.7.2 requested package Microsoft.CodeCoverage: >= 17.7.2 Please try to relax some conditions or resolve the conflict manually (see http://fsprojects.github.io/Paket/nuget-dependencies.html#Use-exactly-this-version-constraint). knocte@knocte-macbook FSharpLintMASTERCLEAN % nano paket.lock knocte@knocte-macbook FSharpLintMASTERCLEAN % dotnet paket install --keep-patch Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c Skipping resolver for group Build since it is already up-to-date Skipping resolver for group Docs since it is already up-to-date Resolving dependency graph... Total time taken: 7 seconds Paket failed with -> There was a version conflict during package resolution. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.TestHost: >= 16.10 < 16.10.1 - Microsoft.NET.Test.Sdk 17.7.2 requested package Microsoft.TestPlatform.TestHost: >= 17.7.2 Please try to relax some conditions or resolve the conflict manually (see http://fsprojects.github.io/Paket/nuget-dependencies.html#Use-exactly-this-version-constraint). knocte@knocte-macbook FSharpLintMASTERCLEAN % nano paket.lock knocte@knocte-macbook FSharpLintMASTERCLEAN % dotnet paket install --keep-patch Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c Skipping resolver for group Build since it is already up-to-date Skipping resolver for group Docs since it is already up-to-date Resolving dependency graph... Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package Microsoft.TestPlatform.ObjectModel: >= 16.10 < 16.10.1 - Microsoft.TestPlatform.TestHost 17.7.2 requested package Microsoft.TestPlatform.ObjectModel: >= 17.7.2 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. ^C% knocte@knocte-macbook FSharpLintMASTERCLEAN % nano paket.lock knocte@knocte-macbook FSharpLintMASTERCLEAN % dotnet paket install --keep-patch Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c Skipping resolver for group Build since it is already up-to-date Skipping resolver for group Docs since it is already up-to-date Resolving dependency graph... Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.7.2 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.7.2 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.7.2 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.7.2 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.7.2 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.8.0 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. Conflict detected: - Dependencies file requested package NuGet.Frameworks: >= 5.10 < 5.10.1 - Microsoft.TestPlatform.ObjectModel 17.7.2 requested package NuGet.Frameworks: >= 6.5 The process is taking longer than expected. Paket may still find a valid resolution, but this might take a while. ^C% knocte@knocte-macbook FSharpLintMASTERCLEAN % nano paket.lock knocte@knocte-macbook FSharpLintMASTERCLEAN % dotnet paket install --keep-patch Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c Skipping resolver for group Build since it is already up-to-date Skipping resolver for group Docs since it is already up-to-date Resolving dependency graph... Updated packages: Group: Main - Microsoft.CodeCoverage: 17.8.0 (added) - Microsoft.NET.Test.Sdk: 17.7.2 (added) - Microsoft.TestPlatform.ObjectModel: 17.8.0 (added) - Microsoft.TestPlatform.TestHost: 17.8.0 (added) - NuGet.Frameworks: 6.8.0 (added) Installing into projects: Created dependency graph (333 packages in total) Downloading Microsoft.NET.Test.Sdk 17.7.2 Could not detect any platforms from 'config' in '/Users/knocte/.nuget/packages/microsoft.codeanalysis.analyzers/3.3.2/build/config/AnalysisLevel_3_AllEnabledByDefault.editorconfig', please tell the package authors Downloading Microsoft.CodeCoverage 17.8.0 Download of Microsoft.NET.Test.Sdk 17.7.2 done in 146 milliseconds. (2205 kbit/s, 0 MB) Downloading Microsoft.TestPlatform.ObjectModel 17.8.0 Download of Microsoft.TestPlatform.ObjectModel 17.8.0 done in 1 second. (7386 kbit/s, 1 MB) Downloading Microsoft.TestPlatform.TestHost 17.8.0 Download of Microsoft.TestPlatform.TestHost 17.8.0 done in 1 second. (12734 kbit/s, 2 MB) Download of Microsoft.CodeCoverage 17.8.0 done in 6 seconds. (11763 kbit/s, 8 MB) - Project FSharpLint.Console.Tests.fsproj needs to be restored - Project FSharpLint.Core.Tests.fsproj needs to be restored - Project FSharpLint.FunctionalTest.fsproj needs to be restored Calling dotnet restore on FSharpLint.sln Determining projects to restore... Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c The last full restore is still up to date. Nothing left to do. The last full restore is still up to date. Nothing left to do. Total time taken: 0 milliseconds Total time taken: 0 milliseconds Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c The last full restore is still up to date. Nothing left to do. Total time taken: 0 milliseconds Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c Paket version 7.2.1+8e4eb74b42fbd45f39f7afce9184c16ebb65f16c paket.dependencies and paket.lock are out of sync in /Users/knocte/Documents/Code/FSharpLintMASTERCLEAN. Please run 'paket install' or 'paket update' to recompute the paket.lock file. Changes were detected for Main/Microsoft.Win32.SystemEvents paket.dependencies and paket.lock are out of sync in /Users/knocte/Documents/Code/FSharpLintMASTERCLEAN. Please run 'paket install' or 'paket update' to recompute the paket.lock file. Changes were detected for Main/Microsoft.Win32.SystemEvents - PackageNotFoundInDependenciesFile Changes were detected for Main/System.Drawing.Common - PackageNotFoundInDependenciesFile Changes were detected for Main/System.Reactive - PackageNotFoundInDependenciesFile Changes were detected for Main/System.Windows.Extensions - PackageNotFoundInDependenciesFile - PackageNotFoundInDependenciesFile Changes were detected for Main/System.Drawing.Common - PackageNotFoundInDependenciesFile Changes were detected for Main/System.Reactive - PackageNotFoundInDependenciesFile Changes were detected for Main/System.Windows.Extensions - PackageNotFoundInDependenciesFile Restoring /Users/knocte/Documents/Code/FSharpLintMASTERCLEAN/tests/FSharpLint.FunctionalTest/FSharpLint.FunctionalTest.fsproj Restoring /Users/knocte/Documents/Code/FSharpLintMASTERCLEAN/tests/FSharpLint.Core.Tests/FSharpLint.Core.Tests.fsproj paket.dependencies and paket.lock are out of sync in /Users/knocte/Documents/Code/FSharpLintMASTERCLEAN. Please run 'paket install' or 'paket update' to recompute the paket.lock file. Changes were detected for Main/Microsoft.Win32.SystemEvents - PackageNotFoundInDependenciesFile Changes were detected for Main/System.Drawing.Common - PackageNotFoundInDependenciesFile Changes were detected for Main/System.Reactive - PackageNotFoundInDependenciesFile Changes were detected for Main/System.Windows.Extensions - PackageNotFoundInDependenciesFile Restoring /Users/knocte/Documents/Code/FSharpLintMASTERCLEAN/tests/FSharpLint.Console.Tests/FSharpLint.Console.Tests.fsproj Starting restore process. Total time taken: 0 milliseconds Starting restore process. Total time taken: 0 milliseconds Starting restore process. Total time taken: 0 milliseconds Restored /Users/knocte/Documents/Code/FSharpLintMASTERCLEAN/tests/FSharpLint.Core.Tests/FSharpLint.Core.Tests.fsproj (in 1.04 sec). Restored /Users/knocte/Documents/Code/FSharpLintMASTERCLEAN/tests/FSharpLint.FunctionalTest/FSharpLint.FunctionalTest.fsproj (in 1.04 sec). Restored /Users/knocte/Documents/Code/FSharpLintMASTERCLEAN/tests/FSharpLint.Console.Tests/FSharpLint.Console.Tests.fsproj (in 1.04 sec). 3 of 6 projects are up-to-date for restore. Total time taken: 1 minute Paket omitted 17 warnings. You can see them in verbose mode. ```
There seems to be no way to fix this problem with the tests throwing the below exception about not finding ConfigurationManager assembly (unless we modify the paket.lock file **manually** like we do in this commit): ``` Starting test execution, please wait... A total of 1 test files matched the specified pattern. Failed FunctionalTestConsoleApplication [651 ms] Error Message: Did not find the following expected errors: [`List.fold ( + ) 0 x` might be able to be refactored into `List.sum x`.,`List.head (List.sort x)` might be able to be refactored into `List.min x`.,`a <> true` might be able to be refactored into `not a`.,`fun x -> x` might be able to be refactored into `id`.,`not (a <> b)` might be able to be refactored into `a = b`.,`not (a = b)` might be able to be refactored into `a <> b`.,`not false` might be able to be refactored into `true`.,`not true` might be able to be refactored into `false`.,`x = null` might be able to be refactored into `isNull x`.] Found the following unexpected warnings: [] Complete output: MSBuild could not load the project file /home/runner/work/FSharpLint/FSharpLint/tests/FSharpLint.FunctionalTest.TestedProject/FSharpLint.FunctionalTest.TestedProject.NetCore/FSharpLint.FunctionalTest.TestedProject.NetCore.fsproj because: InvalidProjectFileMessage "GenericError ("/home/runner/work/FSharpLint/FSharpLint/tests/FSharpLint.FunctionalTest.TestedProject/FSharpLint.FunctionalTest.TestedProject.NetCore/FSharpLint.FunctionalTest.TestedProject.NetCore.fsproj", "Could not load file or assembly 'System.Configuration.ConfigurationManager, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. Could not find or load a specific file. (0x80131621)")" Expected and actual are both <Microsoft.FSharp.Collections.FSharpSet`1[System.String]> Values differ at index [0] Missing: < "`List.fold ( + ) 0 x` might be able to be refactored into `List.sum x`.", ... > Stack Trace: at FSharpLint.FunctionalTest.Tests.TestConsoleApplication.FunctionalTestConsoleApplication() in /home/runner/work/FSharpLint/FSharpLint/tests/FSharpLint.FunctionalTest/TestConsoleApplication.fs:line 108 Failed FunctionalTestConsoleApplicationSolution [649 ms] Error Message: Did not find the following expected errors: [`List.fold ( + ) 0 x` might be able to be refactored into `List.sum x`.,`List.head (List.sort x)` might be able to be refactored into `List.min x`.,`a <> true` might be able to be refactored into `not a`.,`fun x -> x` might be able to be refactored into `id`.,`not (a <> b)` might be able to be refactored into `a = b`.,`not (a = b)` might be able to be refactored into `a <> b`.,`not false` might be able to be refactored into `true`.,`not true` might be able to be refactored into `false`.,`x = null` might be able to be refactored into `isNull x`.] Found the following unexpected warnings: [] Complete output: MSBuild could not load the project file /home/runner/work/FSharpLint/FSharpLint/tests/FSharpLint.FunctionalTest.TestedProject/FSharpLint.FunctionalTest.TestedProject.MultiTarget/FSharpLint.FunctionalTest.TestedProject.MultiTarget.fsproj because: InvalidProjectFileMessage "GenericError ("/home/runner/work/FSharpLint/FSharpLint/tests/FSharpLint.FunctionalTest.TestedProject/FSharpLint.FunctionalTest.TestedProject.MultiTarget/FSharpLint.FunctionalTest.TestedProject.MultiTarget.fsproj", "Could not load file or assembly 'System.Configuration.ConfigurationManager, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. Could not find or load a specific file. (0x80131621)")" Expected and actual are both <Microsoft.FSharp.Collections.FSharpSet`1[System.String]> Values differ at index [0] Missing: < "`List.fold ( + ) 0 x` might be able to be refactored into `List.sum x`.", ... > Stack Trace: at FSharpLint.FunctionalTest.Tests.TestConsoleApplication.FunctionalTestConsoleApplicationSolution() in /home/runner/work/FSharpLint/FSharpLint/tests/FSharpLint.FunctionalTest/TestConsoleApplication.fs:line 124 Failed! - Failed: 2, Passed: 8, Skipped: 0, Total: 10, Duration: 7 s - /home/runner/work/FSharpLint/FSharpLint/tests/FSharpLint.FunctionalTest/bin/Release/net6.0/FSharpLint.FunctionalTest.dll (net6.0) ``` And the idea was actually extracted from PR#606 [1] diff, so we add him as co-author. [1] fsprojects#606 Co-authored-by: Richard Webb <webby@beardmouse.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET5 is out of support, and .NET6 is an LTS version.
Supersedes #606
Closes #606
Co-authored-by:
Richard Webb <webby@beardmouse.co.uk>