Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the 'setup-dotnet' action in the CI build #614

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update the 'setup-dotnet' action in the CI build #614

merged 1 commit into from
Dec 7, 2023

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Nov 21, 2023

Just an observation that there are several warnings in the CI builds about using old versions of the actions:

image

I don't know how important it actually is, but it does remove a bit of noise, so here it is if its considered useful

@knocte
Copy link
Collaborator

knocte commented Nov 22, 2023

Just a nitpick: now that we're upgrading, let's upgrade to last version? I think v3 is not the last.

@Numpsy
Copy link
Contributor Author

Numpsy commented Nov 22, 2023

I was under the impression that setting it to just 'v3' rather than the full version would cause it to use the latest 3.x release? (3.2.0 as it stands)

@knocte
Copy link
Collaborator

knocte commented Nov 22, 2023

Oh interesting. Then I guess this can go in. That said, pinning to a specific version is always more "stable" in a way, because we would prevent being affected by bugs (regression) that might happen in the latest versions which might leave us scratching our heads.

@Numpsy
Copy link
Contributor Author

Numpsy commented Nov 22, 2023

I believe that you can set it to a specific version and then set up dependabot to prompt about updates, but I've never tried setting that up myself

@knocte knocte merged commit 3d9647d into fsprojects:master Dec 7, 2023
@Numpsy Numpsy deleted the rw/actions branch December 8, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants