Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing version #612

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

Thorium
Copy link
Member

@Thorium Thorium commented Nov 18, 2023

This will add --version argument for printing version, with GitHub commit-id e.g.
"1.0.0+2cfaef9576731e7852852518b730349341b069d9"

Fix for #611

"1.0.0+2cfaef9576731e7852852518b730349341b069d9"
@knocte
Copy link
Collaborator

knocte commented Nov 20, 2023

Hey @Thorium thanks for your PR! Looks good in principle, just gonna point out some nits.

@Thorium
Copy link
Member Author

Thorium commented Nov 20, 2023

Hey @Thorium thanks for your PR! Looks good in principle, just gonna point out some nits.

Done.

@knocte
Copy link
Collaborator

knocte commented Nov 22, 2023

So I assume you tested your own PR? Just making sure, because it's very surprising to me that you can get the commit hash out of some reflection API.

@Thorium
Copy link
Member Author

Thorium commented Nov 22, 2023

I originally took the code from Paket repository, and that is used a lot :-)

@Thorium
Copy link
Member Author

Thorium commented Nov 22, 2023

This codebase is using Paket, I think that puts commit hash to AssemblyInfo style attributes.

@Numpsy
Copy link
Contributor

Numpsy commented Nov 22, 2023

The binaries are sourcelinked, and the sourcelink tools can insert the git commit info into the assembly version information.

@knocte
Copy link
Collaborator

knocte commented Nov 23, 2023

This codebase is using Paket, I think that puts commit hash to AssemblyInfo style attributes.

It uses Paket to restore, I doubt it uses Paket to pack, because it is Fake the tool that is packing, right? See https://github.com/fsprojects/FSharpLint/blob/master/build.fsx#L124

The binaries are sourcelinked, and the sourcelink tools can insert the git commit info into the assembly version information.

Oh interesting! I guess I missed the commit that introduced SourceLink support, must be old (before I became maintainer); will investigate.

@knocte knocte merged commit 93f514b into fsprojects:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants