-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2 new rules NestedFunctionNames and UnnestedFunctionNames #564
Conversation
src/FSharpLint.Core/Rules/Conventions/Naming/UnnestedFunctionNames.fs
Outdated
Show resolved
Hide resolved
LGTM, let's squash all commits into 1? (Use |
639d9cc
to
064444f
Compare
It should be the other way around: Retheesh be the author of the commit (as the majority of the code is his), but add yourself in the |
064444f
to
31a1fba
Compare
Why do I see 6 commits now in this PR instead of 1 or 2? Commit 31a1fba looks correct and you should've used --amend to that one. |
For some reason my local |
And when pulling I guess you didn't use the flag --rebase. |
No |
That's the reason then. Please always use --rebase when pulling, otherwise it causes this kind of weird merges/messes. |
@webwarrior-ws can you rebase this please (also pls update the "Introduced in" text in docs). |
ping |
fa42119
to
a1dfcca
Compare
@knocte |
d849fdd
to
e4110c4
Compare
tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/NestedFunctionNames.fs
Show resolved
Hide resolved
tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/UnnestedFunctionNames.fs
Show resolved
Hide resolved
Add NestedFunctionNames and UnnestedFunctionNames rules. These rules allow configuring naming conventions for nested and unnested function names.
Refactoring in getFunctionIdents function: - made paramters explicit - simplified pattern matching
Removed unused _accessibility argument in getFunctionIdents function. Extracted AccessControlLevel.Public to temp variable in nested and unnested function names rules.
Changed names of some local vars and parameters in NestedFunctionNames.fs and UnestedFunctionNames.fs.
510a432
to
4e9d385
Compare
These rules allow configuring naming conventions for nested and unnested function names.