Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 new rules NestedFunctionNames and UnnestedFunctionNames #564

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

webwarrior-ws
Copy link
Contributor

These rules allow configuring naming conventions for nested and unnested function names.

@knocte
Copy link
Collaborator

knocte commented Aug 10, 2022

LGTM, let's squash all commits into 1? (Use Co-authored-by: Name Surname <email@address.com> tag in commit message.)

@knocte
Copy link
Collaborator

knocte commented Aug 10, 2022

From 064444fec757bf273cf6e0d856838dea3179a214 Mon Sep 17 00:00:00 2001
From: webwarrior <reg@webwarrior.ws>
Date: Wed, 27 Oct 2021 06:48:56 +0200
Subject: [PATCH] Add 2 new rules NestedFunctionNames and UnnestedFunctionNames

These rules allow configuring naming conventions for nested and unnested function names.

Co-authored-by: Retheesh Erathu <sumod8898@gmail.com>

It should be the other way around: Retheesh be the author of the commit (as the majority of the code is his), but add yourself in the Co-authored-by tag.

@knocte
Copy link
Collaborator

knocte commented Aug 24, 2022

Why do I see 6 commits now in this PR instead of 1 or 2? Commit 31a1fba looks correct and you should've used --amend to that one.

@webwarrior-ws
Copy link
Contributor Author

Why do I see 6 commits now in this PR instead of 1 or 2? Commit 31a1fba looks correct and you should've used --amend to that one.

For some reason my local function-names branch was unsynchronized with remote one. So I pulled and pushed.

@knocte
Copy link
Collaborator

knocte commented Aug 24, 2022

And when pulling I guess you didn't use the flag --rebase.

@webwarrior-ws
Copy link
Contributor Author

No

@knocte
Copy link
Collaborator

knocte commented Aug 24, 2022

That's the reason then. Please always use --rebase when pulling, otherwise it causes this kind of weird merges/messes.

@knocte
Copy link
Collaborator

knocte commented Dec 7, 2023

@webwarrior-ws can you rebase this please (also pls update the "Introduced in" text in docs).

@knocte
Copy link
Collaborator

knocte commented Dec 16, 2023

@webwarrior-ws can you rebase this please (also pls update the "Introduced in" text in docs).

ping

@webwarrior-ws webwarrior-ws force-pushed the function-names branch 3 times, most recently from fa42119 to a1dfcca Compare December 18, 2023 09:45
@webwarrior-ws
Copy link
Contributor Author

@knocte
Rebased on top of latest master branch.

su8898 and others added 3 commits December 19, 2023 11:06
Add NestedFunctionNames and UnnestedFunctionNames rules.
These rules allow configuring naming conventions for nested and
unnested function names.
Refactoring in getFunctionIdents function:
- made paramters explicit
- simplified pattern matching
Removed unused _accessibility argument in getFunctionIdents
function. Extracted AccessControlLevel.Public to temp variable
in nested and unnested function names rules.
Changed names of some local vars and parameters in
NestedFunctionNames.fs and UnestedFunctionNames.fs.
@knocte knocte merged commit 0de3a60 into fsprojects:master Dec 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants