Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharpLint is not passing its own source-code #609

Closed
Thorium opened this issue Nov 8, 2023 · 1 comment · Fixed by #628
Closed

FSharpLint is not passing its own source-code #609

Thorium opened this issue Nov 8, 2023 · 1 comment · Fixed by #628

Comments

@Thorium
Copy link
Member

Thorium commented Nov 8, 2023

Description

Running F# Lint to its own source-code is not passing.
This makes me think some of the default rules are not good, if the linter itself doesn't obey those rules.
So consider turning the hitting rules off by default.

Repro steps

Clone this repo, build, and run:

C:\git\FSharpLint\src\FSharpLint.Console>dotnet run --framework net5.0 lint c:\git\FSharpLint\src\FSharpLint.Core\FSharpLint.Core.fsproj

Expected behavior

Pass with no complaints.

Actual behavior

Mostly it will hit just generic argument not being in PascalCase:

Consider changing `t` to PascalCase.
Error on line 87 starting at column 16
    type Result<'t> =
                ^

Consider changing `key` to PascalCase.
Error on line 18 starting at column 47
    let addOrUpdate key value (dict:Dictionary<'key,'value>) =
                                               ^

Would default camelCase be ok for type-arguments?

Related information

  • Operating system Windows 11
  • Branch master
  • .NET Runtime, CoreCLR or Mono Version .NET 5
@bartelink
Copy link
Member

If this is the only failing rule, I'd roll this issue in with #610 (comment)

knocte pushed a commit to Mersho/FSharpLint that referenced this issue Dec 13, 2023
Fixes fsprojects#609

Co-authored-by: Parham <parhaamsaremi@gmail.com>
knocte added a commit that referenced this issue Dec 13, 2023
CI: run FSharpLint on itself.

Fixes #609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants