Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dynamic DB docs #357

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Improve dynamic DB docs #357

merged 2 commits into from
Oct 31, 2019

Conversation

cmeeren
Copy link
Contributor

@cmeeren cmeeren commented Sep 27, 2019

Closes #356

I wasn't able to generate the docs; there were warnings errors all over the place when executing the build script. I don't think they were related to my changes. Feel free to test yourselves. :)

@cmeeren
Copy link
Contributor Author

cmeeren commented Oct 2, 2019

Any chance to have a look at merging this?

@cmeeren
Copy link
Contributor Author

cmeeren commented Oct 10, 2019

Is this waiting for anything in particular? Anything I can do to help?

@smoothdeveloper
Copy link
Collaborator

@cmeeren, waiting for someone to pull it , compile / check the doc, maybe play around with it, push new docs to git branch for it to be online.

In my case, I can't deal with it right now, and when I'll be able to do, it will be when I can allocate a large enough buffer of time to tinker with the library beside a small doc update.

If you have the docs compiled already, you can make a PR against https://github.com/fsprojects/FSharp.Data.SqlClient/tree/gh-pages which I will review / merge in shorter amount of time.

Hope that makes sense.

@cmeeren
Copy link
Contributor Author

cmeeren commented Oct 10, 2019

Thanks, I see. Unfortunately I haven't been able to compile the docs. No worries, take it on your own time. 👍

@smoothdeveloper smoothdeveloper merged commit c8148eb into fsprojects:master Oct 31, 2019
@smoothdeveloper
Copy link
Collaborator

@cmeeren thanks for your PR.

@cmeeren cmeeren deleted the improve-dynamic-db-docs branch November 1, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "dynamic creation of offline MDF" docs
2 participants