Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chocolatey package structure update #1613

Conversation

vlukash
Copy link
Contributor

@vlukash vlukash commented Jul 11, 2017

Keep content and structure in sync for Chocolatey and NuGet packages.

Currently the nuget/dotnetcore/chocolatey/fake.nupkg is generated based on the nuget\dotnetcore\Fake.netcore\win7-x86, which is wrong

Changing the source to .build folder, the same as for NuGet generation.

Chocolatey structure changes:

  • use tools folder instead of bin

Targets changes:

  • CreateChocolateyPackage - new, use instead of DotnetCoreCreateChocolateyPackage
  • PushChocolateyPackage - new, use instead of DotnetCorePushChocolateyPackage
  • DotnetCoreCreateChocolateyPackage - removed
  • DotnetCorePushChocolateyPackage - removed

vlukash added 2 commits July 11, 2017 02:21
CreateChocolateyPackage and PushChocolateyPackage targets are created for FAKE Chocolatey package.
Remove DotnetCoreCreateChocolateyPackage and DotnetCorePushChocolateyPackage targets.
Use CreateChocolateyPackage and PushChocolateyPackage instead.
@vlukash vlukash changed the title WIP: Chocolatey package structure update Chocolatey package structure update Jul 11, 2017
@matthid
Copy link
Member

matthid commented Jul 11, 2017

I think this works because it moves the nupkg into a different folder. Can you please explain why we need the bin -> tools folder name change within the package? Did you test if this actually works with choco?

@vlukash
Copy link
Contributor Author

vlukash commented Jul 12, 2017

Seems like it's not important to change bin -> tools in this case.
It works with the current structure well.

Originally this PR was created to address an issue with Chocolatey caching but that issue is not relevant anymore.
So I can revert bin->tools change.

Did you test if this actually works with choco?
yes, I've installed FAKE from local nupkg and it worked out:
choco install fake -s fake.nupkg

If we want to use the same *.dlls in Chocolatey as NuGet uses then we can keep this PR.

But if using *.dlls from dotnet core is not an issue then this PR should be deleted and no changes needed.

@matthid
Copy link
Member

matthid commented Jul 26, 2017

Yes I agree, we don't need a shared nuget/choco package. So if somebody has the same problem the solution is updating chocolatey...

@matthid matthid closed this Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants