-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create FS-1105-Non-variable-patterns-to-the-right-of-as-patterns.md #595
Conversation
drafts/FS-1105-Non-variable-patterns-to-the-right-of-as-patterns.md
Outdated
Show resolved
Hide resolved
…ns.md Co-authored-by: Gauthier Segay <smoothdeveloper@users.noreply.github.com>
@Happypig375 Might be easier for others to review if you add something like a Rendered hyperlink that links to your RFC file in your branch. Like the link in this Rust RFC PR sample: rust-lang/rfcs#3137 |
Is it that hard to click "Files changed" -> "..." -> "View file"? Rendered |
Up until now, I had no idea you could do that. I try to assume my reviewers don't keep up with github features either. 🙂 |
There is also the opportunity to make |
I don't think this should be included. The pattern on the left matches type "int", the pattern on the right matches type "obj". We should tighten typing on a left-to right basis, so yes to |
No description provided.