Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FS-1105-Non-variable-patterns-to-the-right-of-as-patterns.md #595

Merged
merged 8 commits into from
Jun 16, 2021

Conversation

Happypig375
Copy link
Contributor

No description provided.

…ns.md

Co-authored-by: Gauthier Segay <smoothdeveloper@users.noreply.github.com>
@Swoorup
Copy link
Contributor

Swoorup commented Jun 10, 2021

@Happypig375 Might be easier for others to review if you add something like a Rendered hyperlink that links to your RFC file in your branch.

Like the link in this Rust RFC PR sample: rust-lang/rfcs#3137

@Happypig375
Copy link
Contributor Author

Is it that hard to click "Files changed" -> "..." -> "View file"? Rendered

@Swoorup
Copy link
Contributor

Swoorup commented Jun 10, 2021

Up until now, I had no idea you could do that. I try to assume my reviewers don't keep up with github features either. 🙂

Happypig375 added a commit to Happypig375/fslang-design that referenced this pull request Jun 10, 2021
@Happypig375
Copy link
Contributor Author

There is also the opportunity to make 1 | 2 as :? int happen. This will save one level of parentheses over :? int as (1 | 2). What are your thoughts?

@dsyme
Copy link
Contributor

dsyme commented Jun 14, 2021

There is also the opportunity to make 1 | 2 as :? int happen. This will save one level of parentheses over :? int as (1 | 2). What are your thoughts?

I don't think this should be included. The pattern on the left matches type "int", the pattern on the right matches type "obj". We should tighten typing on a left-to right basis, so yes to :? int as 3 and not 3 as :? int

@dsyme dsyme merged commit 04fdb8a into fsharp:main Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants