comment: fix GNU ld and as files #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 4, 2024 21:56
As per documentation: "You may include comments in linker scripts just as in C: delimited by `/*' and `*/'." Link: https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_chapter/ld_3.html#SEC6 Signed-off-by: Anthony Loiseau <anthony@loiseau.fr>
As well described by sourceware website [1]:
There are two ways of rendering comments to as:
- Anything from ‘/*’ through the next ‘*/’ is a comment.
- The line comment character is target specific
We therefore better should use the C style comment instead of any
single-line comment which can't fit every cases.
Wikipedia [2] provides a list of target-specific GNU as single-line comments:
- A hash symbol (#) — i386, x86-64, i960, 68HC11, 68HC12, VAX, V850, M32R,
PowerPC, MIPS, M680x0, and RISC-V
- A semicolon (;) — AMD 29k family, ARC, H8/300 family, HPPA, PDP-11,
picoJava, Motorola, and M32C
- The at sign (@) — 32-bit ARM
- A double slash (//) — AArch64
- A vertical bar (|) — M680x0
- An exclamation mark (!) — Renesas SH
[1]: https://sourceware.org/binutils/docs/as.html#Comments
[2]: https://en.wikipedia.org/wiki/GNU_Assembler
Signed-off-by: Anthony Loiseau <anthony@loiseau.fr>
Signed-off-by: Anthony Loiseau <anthony@loiseau.fr>
As per pull request checklist. Signed-off-by: Anthony Loiseau <anthony@loiseau.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comment: fix GNU as comment style (*.s)
As well described by sourceware website [1]:
There are two ways of rendering comments to as:
/*through the next*/is a comment.We therefore better should use the C style comment instead of any single-line comment which can't fit every cases.
Wikipedia [2] provides a list of target-specific GNU as single-line comments:
PowerPC, MIPS, M680x0, and RISC-V
picoJava, Motorola, and M32C
Hash symbol is currently used, this PR make it
/* */comment: fix GNU ld comment style (*.ld)
As per documentation: "You may include comments in linker scripts just as in C: delimited by
/*and*/."Link: https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_chapter/ld_3.html#SEC6
changelog.d/<directory>/.AUTHORS.rst.[ ] Wrote tests.==> Don't think this desserves a new test[ ] Documented my changes in==> Don't think this desserves a docdocs/man/or elsewhere.the current specification.
changed files.