Filter headers in docs to make it less chatty #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timurvafin
commented
Aug 14, 2015
timurvafin
commented
- Leave only 'Accept', 'X-Auth-Token' in request headers
- Leave only Content-Type in response headers
- Remove Origin from CURL request headers
* Leave only 'Accept', 'X-Auth-Token' in request headers * Leave only Content-Type in response headers * Remove Origin from CURL request headers
timurvafin
force-pushed
the
filter-headers-in-docs
branch
from
7688e27
to
c9689bf
Compare
| "request_content_type": "application/x-www-form-urlencoded", | ||
| "response_status": 201, | ||
| "response_status_text": "Created", | ||
| "response_body": "{\"user\":{\"id\":2,\"authentication_token\":\"hS-Wnfqrszhbgy_C8kEW\",\"email\":\"user2@example.com\"}}", |
There was a problem hiding this comment.
just wondering, do we hide responses containing authentication_token and authentication_token itself from loggers?
There was a problem hiding this comment.
I've created issue for that #179, thank you!
|
👍 |
timurvafin
added a commit
that referenced
this pull request
Aug 14, 2015
Filter headers in docs to make it less chatty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.