Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/codehilite): ValueError in parse_extras (closes #147) #148

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

llllvvuu
Copy link
Contributor

@llllvvuu llllvvuu commented Jun 9, 2023

closes #147

marko/ext/codehilite.py Outdated Show resolved Hide resolved
@frostming
Copy link
Owner

Good catch, thanks

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 70.00% and project coverage change: -0.15 ⚠️

Comparison is base (cc43584) 96.86% compared to head (f1a9703) 96.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   96.86%   96.71%   -0.15%     
==========================================
  Files          19       19              
  Lines        1880     1889       +9     
  Branches      320      321       +1     
==========================================
+ Hits         1821     1827       +6     
- Misses         30       32       +2     
- Partials       29       30       +1     
Flag Coverage Δ
unittests 96.71% <70.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
marko/ext/codehilite.py 92.10% <70.00%> (-7.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 9e98da8 into frostming:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ext/codehilite.py: Putting "```text like this" causes ValueError in _parse_extras
2 participants