Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make strikethrough precedence the default; add strikethrough tests #136

Merged
merged 4 commits into from
Jan 28, 2023

Conversation

KevinMGranger
Copy link
Contributor

I noticed that strikethroughs were parsing incorrectly. If they have lower precedence than a link, then they'll break both themselves and the link!

I added a test for that case, as well as for examples from the GFM spec. I also added python 3.11 to the list of nox pythons.

The example for triple-strikes not changing into <del> still doesn't pass, but that seems more involved to fix, and should be a separate issue / PR.

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 95.31% // Head: 95.47% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (6161223) compared to base (bafe94d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   95.31%   95.47%   +0.15%     
==========================================
  Files          19       19              
  Lines        1877     1877              
  Branches      320      320              
==========================================
+ Hits         1789     1792       +3     
+ Misses         46       44       -2     
+ Partials       42       41       -1     
Flag Coverage Δ
unittests 95.47% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
marko/ext/gfm/elements.py 81.87% <100.00%> (+1.25%) ⬆️
marko/ext/gfm/__init__.py 88.63% <0.00%> (+2.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 7b31460 into frostming:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants