-
Notifications
You must be signed in to change notification settings - Fork 257
Conversation
Before running eslint, because it seems to fail if there are any expired artifacts.
|
Because the first purge pass hit the rate limit.
I keep hitting the rate limit. I'll wait a while and retrigger the purge action again. |
It seems like there are many artifacts, so maybe it'd be better to merge this and let it run each 15 minutes until they are all gone. @SantosGuillamot, would mind taking a look and approving this PR? Thanks. |
I've seen that in the GitHub action you added, LKP-RnD/purge-expired-artifacts-action@v4, they mention as a common issue this: "If you have thousands of expired artifacts the action won't be able to delete everything in one go as githubs API has a rate limit. However, if you run it on a schedule as in the example every other hour you will eventually come to a point where the script will have cleared most unused artifacts and this will no longer cause problems." Checking the repo in GitHub artifacts API, it seems that there are 4583. So I guess this could be the problem. I guess we have to remove the artifacts manually or, as they suggest, implement a CRON workflow triggering the action you added. |
The CRON is already set up for this action. That is the reason I thought we may just merge this and let it fun each 15 minutes until they are all gone 🙂 |
Oh, I was just writing my answer 🙂 . Triggering it removed like 300 artifacts, so we'll need it to run a few times until all of them are deleted.
Sure, I was already on it. Approving it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Haha, ok, we were talking about the same at the same time 😄 Thanks Mario, I'll merge it now and I'll keep an eye on the action runs after that. |
BTW, these are the action run by the workflow each 15 min: https://github.com/frontity/frontity/actions/workflows/eslint.yml |
I saw it in the changed files, thanks Luis 🙂 Btw, I think I can trigger it manually until the artifacts are gone. There are 3884 left -> https://api.github.com/repos/frontity/frontity/actions/artifacts |
What:
Purge the expired artifacts.
Why:
Because the Eslint GH action is failing a lot lately and it seems like expired artifacts can be the cause, acording to this issue: bradennapier/eslint-plus-action#45.
How:
By adding a previous step in the Eslint GH action that purges the expired artifacts before eslint runs.
Tasks:
Unrelated Tasks
Additional Comments