FronteggError Enum Granularity #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR extracts all errors thrown by the SDK into strongly typed errors whilst keeping the same messaging as the current live version of the SDK.
This approach adds support for an additional level of granularity when it comes to handling errors on the client side.
Reasoning
The current implementation throws two types of errors (
configErrorandauthError), but the associated values of those enum cases are both Strings, which doesn't allow for disambiguation of the error message at the client level. Because of this, clients can only distinguish betweenconfigErrorandauthError, so barring any exact string checks on the client side, it is not possible to display custom error messages for each situation.An example of such scenario is presenting different error messages when the user cancels the authentication session versus a failed authentication error.
Another example is the localisation of the errors thrown into multiple languages on the client side.
The approach in this PR addresses both of these issues.