Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated so that devtools depends on core, and no dependency on devtools from core. #382

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

seanspeaks
Copy link
Contributor

@seanspeaks seanspeaks commented Feb 20, 2025

TL;DR

Updated dependencies across core and devtools packages to align versions and add new required packages.

What changed?

  • Added new dependencies to core:
    • form-data
    • fs-extra
    • uuid
  • Removed dependencies from core:
    • jest-runner-groups
    • mongodb-memory-server
    • lodash.get
  • Updated @hapi/boom in devtools from 7.4.11 to 10.0.1
  • Standardized lodash version to 4.17.21
  • Aligned prettier version to 2.7.1 across packages

How to test?

  1. Delete node_modules and package-lock.json
  2. Run npm install
  3. Verify the application builds successfully
  4. Run existing tests to ensure functionality remains intact

Why make this change?

To maintain consistent dependency versions across packages, remove unused dependencies, and add new required packages for upcoming features. This helps prevent version conflicts and reduces the overall package size by removing unnecessary dependencies.

📦 Published PR as canary version: 2.0.0--canary.382.cb1e673.0

✨ Test out this PR locally via:

npm install @friggframework/core@2.0.0--canary.382.cb1e673.0
npm install @friggframework/devtools@2.0.0--canary.382.cb1e673.0
npm install @friggframework/eslint-config@2.0.0--canary.382.cb1e673.0
npm install @friggframework/prettier-config@2.0.0--canary.382.cb1e673.0
npm install @friggframework/serverless-plugin@2.0.0--canary.382.cb1e673.0
npm install @friggframework/test@2.0.0--canary.382.cb1e673.0
npm install @friggframework/ui@2.0.0--canary.382.cb1e673.0
# or 
yarn add @friggframework/core@2.0.0--canary.382.cb1e673.0
yarn add @friggframework/devtools@2.0.0--canary.382.cb1e673.0
yarn add @friggframework/eslint-config@2.0.0--canary.382.cb1e673.0
yarn add @friggframework/prettier-config@2.0.0--canary.382.cb1e673.0
yarn add @friggframework/serverless-plugin@2.0.0--canary.382.cb1e673.0
yarn add @friggframework/test@2.0.0--canary.382.cb1e673.0
yarn add @friggframework/ui@2.0.0--canary.382.cb1e673.0

Version

Published prerelease version: v2.0.0-next.15

Changelog

🐛 Bug Fix

  • @friggframework/core, @friggframework/devtools
    • Updated so that devtools depends on core, and no dependency on devtools from core. #382 (@seanspeaks)
  • @friggframework/core, @friggframework/devtools, @friggframework/eslint-config, @friggframework/prettier-config, @friggframework/serverless-plugin, @friggframework/test, @friggframework/ui
    • Updated so that devtools depends on core, and no dependency on devtools from core. #381 (@seanspeaks)

Authors: 1

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@seanspeaks seanspeaks force-pushed the devtool-dependency-from-core branch from ed501ae to cb1e673 Compare February 20, 2025 17:20
@seanspeaks seanspeaks added the release Create a release when this pr is merged label Feb 20, 2025 — with Graphite App
@seanspeaks seanspeaks marked this pull request as ready for review February 20, 2025 17:21
@seanspeaks seanspeaks merged commit a25554c into next Feb 20, 2025
7 of 8 checks passed
Copy link
Contributor Author

Merge activity

  • Feb 20, 12:21 PM EST: A user merged this pull request with Graphite.

@seanspeaks
Copy link
Contributor Author

🚀 PR was released in v2.0.0-next.15 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prerelease This change is available in a prerelease. release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant