Add the team entity to Slack if it doesn't exists and return it in pr… #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocessAuthorizationCallback
MichaelRyanWebber
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
I wanted to suggest potentially renaming the findOrCreateEntity method to: findOrCreateUserEntity, if that is its exclusive role.
I think I understand these changes, but it is a bit unclear. Seems to be creating both a user and team based entity, if both contexts are available. And if I have that right, then I think this makes sense.
|
Kudos, SonarCloud Quality Gate passed!
|
|
🚀 PR was released in |
seanspeaks
deleted the
feature/lef-789-save-user-token-if-it-exists-instead-of-bot-token
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically creates and returns the team entity in Slack, in case user scopes exist in the auth flow.
If there is no user scopes provided, it just creates the team entity.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @friggframework/api-module-slack@0.2.2-canary.221.3ee830b.0 # or yarn add @friggframework/api-module-slack@0.2.2-canary.221.3ee830b.0