Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Add Sharepoint graphSearchQuery function #217

Merged

Conversation

Max-SDSharp
Copy link
Contributor

@Max-SDSharp Max-SDSharp commented Aug 27, 2023

Add Sharepoint graphSearchQuery function

πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @friggframework/api-module-frontify@1.0.2-canary.217.dc55463.0
npm install @friggframework/api-module-microsoft-sharepoint@0.0.8-canary.217.dc55463.0
# or 
yarn add @friggframework/api-module-frontify@1.0.2-canary.217.dc55463.0
yarn add @friggframework/api-module-microsoft-sharepoint@0.0.8-canary.217.dc55463.0

@Max-SDSharp Max-SDSharp requested a review from leofmds August 27, 2023 20:38
@linear
Copy link

linear bot commented Aug 27, 2023

@ghost
Copy link

ghost commented Aug 27, 2023

πŸ‘‡ Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@leofmds leofmds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just add a missing test to the function and remove unnecessary log

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

@Max-SDSharp Max-SDSharp requested a review from leofmds August 30, 2023 17:07
Copy link
Contributor

@leofmds leofmds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ»

@leofmds leofmds merged commit 93dc0b4 into main Sep 6, 2023
@seanspeaks
Copy link
Contributor

@seanspeaks seanspeaks added the released This issue/pull request has been released. label Sep 6, 2023
@Max-SDSharp Max-SDSharp deleted the feature/lef-418-search-filter-ui-from-filter-options-endpoint branch September 6, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants