Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lef 388 upload assets function #187

Merged
merged 10 commits into from
Jun 28, 2023

Conversation

roboli
Copy link
Contributor

@roboli roboli commented Jun 27, 2023

Implement the following methods to upload a file coming from Canva to Frontify:

  • createFileId
  • uploadFile
  • createAsset
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @friggframework/api-module-frontify@0.0.7-canary.187.ce0b6a0.0
# or 
yarn add @friggframework/api-module-frontify@0.0.7-canary.187.ce0b6a0.0

@linear
Copy link

linear bot commented Jun 27, 2023

LEF-388 Upload assets function

Implement the Frontify upload for DAM upload route and event

@ghost
Copy link

ghost commented Jun 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@roboli roboli force-pushed the feature/lef-388-upload-assets-function branch from 4599998 to ce0b6a0 Compare June 27, 2023 23:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@roboli roboli requested a review from leofmds June 28, 2023 17:44
Copy link
Contributor

@leofmds leofmds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@leofmds leofmds merged commit 1ba0bcc into main Jun 28, 2023
@seanspeaks
Copy link
Contributor

🚀 PR was released in @friggframework/api-module-frontify@0.0.7 🚀

@seanspeaks seanspeaks added the released This issue/pull request has been released. label Jun 28, 2023
@roboli roboli deleted the feature/lef-388-upload-assets-function branch June 28, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants