Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lef 259 frontify functionality checklist #180

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

leofmds
Copy link
Contributor

@leofmds leofmds commented Jun 14, 2023

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @friggframework/api-module-frontify@0.0.5-canary.180.a021c7e.0
# or 
yarn add @friggframework/api-module-frontify@0.0.5-canary.180.a021c7e.0

@linear
Copy link

linear bot commented Jun 14, 2023

LEF-259 Frontify Functionality Checklist

Go through all functionality

1 - Ensure tests for Frontify in Canva Frigg are working (test/managers/integration/FrontifyIntegration)
2 - Test the Canva App calling backend requests and ensure they are working as expected, i.e. showing all data the frontend expects.
For the frontend, first, you could run the app by using mocks in the backend, which should be working fine since it was tested a few days ago. Then, change the backend for live data (useMocks = false) and ensure the app continues to work.

@leofmds leofmds requested review from roboli and seanspeaks June 14, 2023 14:21
@ghost
Copy link

ghost commented Jun 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@roboli
Copy link
Contributor

roboli commented Jun 14, 2023

All good!

@roboli roboli merged commit a021c7e into main Jun 14, 2023
@seanspeaks seanspeaks added the released This issue/pull request has been released. label Jun 14, 2023
@seanspeaks
Copy link
Contributor

🚀 PR was released in @friggframework/api-module-frontify@0.0.6 🚀

@seanspeaks seanspeaks deleted the feature/lef-259-frontify-functionality-checklist branch June 20, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants