Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some tests and change API request method #146

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Added some tests and change API request method #146

merged 1 commit into from
Apr 10, 2023

Conversation

seanspeaks
Copy link
Contributor

Bug, "Get" methods in Slack are actually POSTs, since Slack's API is a JSON RPC

@seanspeaks seanspeaks merged commit 3796479 into main Apr 10, 2023
@ghost
Copy link

ghost commented Apr 10, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@seanspeaks
Copy link
Contributor Author

🚀 PR was released in @friggframework/api-module-slack@0.1.31 🚀

@seanspeaks seanspeaks added the released This issue/pull request has been released. label Apr 10, 2023
@seanspeaks seanspeaks deleted the api-module-library/slack-get-channel-history-bug branch April 26, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seanspeaks