Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement postEphemeral method for Slack #137

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

roboli
Copy link
Contributor

@roboli roboli commented Mar 23, 2023

Could it be that simple @seanspeaks ?

πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @friggframework/api-module-slack@0.1.26-canary.137.9272ed2.0
# or 
yarn add @friggframework/api-module-slack@0.1.26-canary.137.9272ed2.0

@roboli roboli requested a review from seanspeaks March 23, 2023 15:56
@ghost
Copy link

ghost commented Mar 23, 2023

πŸ‘‡ Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@seanspeaks seanspeaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! That simple πŸ‘

@roboli
Copy link
Contributor Author

roboli commented Mar 23, 2023

Yup! That simple +1

What are next steps @seanspeaks ? Should I only merge 😳

@seanspeaks seanspeaks merged commit 3dd11d6 into main Mar 23, 2023
@seanspeaks
Copy link
Contributor

(@roboli Yup, flow is PR owner does the merge upon approval πŸ‘ )

@seanspeaks
Copy link
Contributor

πŸš€ PR was released in @friggframework/api-module-slack@0.1.26 πŸš€

@seanspeaks seanspeaks added the released This issue/pull request has been released. label Mar 23, 2023
@roboli roboli deleted the fr/slack-post-ephemeral branch March 25, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants