-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot access URLs #1607
Comments
Thanks for reporting it's a bug! |
I made a failed attempt to fix the github links, so for the next attempt (or if anyone wants to try to fix this), here is what happens : due to the Instead, the URL provided in the issue is a plain URL pointing to a plain JSON file, and I suspect the same holds for the zenodo URL. A possible solution might be to check if the URL has the expected shape before dispatching it to a data portal ( |
- fixes part of #1607 In the absence of other hints (e.g. a Controller object associated to another plugin), all URLs from `github.com` were being processed by the `GithubPlugin`, to create a Github Data Portal adapter. With this PR, `GithubPlugin` only handles the URL if it has the expected format "https://github.com/user_or_org/repo", and "https://github.com/user_or_org", otherwise it is passed other to be treated as a plain URL. I also made some refactorings along the way, to have more readable and less nested code. As tests github portal are currently skipped, I checked manually that I have not broken this functionality.
Overview
I am curating a data project where we make datapackages available both on GitHub and on Zenodo. So far, I have never managed to access data on the web using the frictionless framework.
Setup
I have installed the framework (version 5.16.0) using
pip install -U frictionless[zenodo,visidata]
.GitHub Fail
Our workflow publishes datapackages with every GitHub release such as this one here.
Since everyone can access the file
I would expect to be able to
or to
but in both cases I get
I hope it's just that I overlooked the relevant bit in the documentation which I have extensively searched. Nevertheless, from my understanding of Frictionless this should "just work".
Zenodo Fail
Likewise, take this Zenodo record.
It provides the datapackage
so I would like to
but I get
Am I doing something wrong?
The text was updated successfully, but these errors were encountered: