Update the save() method to set relative paths for resources. Fixes frictionlessdata#41.

src/Datapackages/BaseDatapackage.php

@@ -183,20 +183,31 @@ public function save($zip_filename)
     {
         Package::isZipPresent();
         $zip = new ZipArchive();
+
+        $packageCopy = $this->copy();
+
         $base = tempnam(sys_get_temp_dir(), 'datapackage-zip-');
         $files = [
             'datapackage.json' => $base.'datapackage.json',
         ];
         $ri = 0;
-        foreach ($this as $resource) {
+        foreach ($packageCopy as $resource) {
+            if ($resource->isRemote()) {
+                continue;
+            }
+
+            $resourceFiles = [];
             $fileNames = $resource->save($base.'resource-'.$ri);
             foreach ($fileNames as $fileName) {
                 $relname = str_replace($base.'resource-'.$ri, '', $fileName);
                 $files['resource-'.$ri.$relname] = $fileName;
+                $resourceFiles[] = 'resource-'.$ri.$relname;
             }
+            $resource->descriptor()->path = count($resourceFiles) == 1 ? $resourceFiles[0] : $resourceFiles;
             ++$ri;
         }
-        $this->saveDescriptor($files['datapackage.json']);
+        $packageCopy->saveDescriptor($files['datapackage.json']);
+
         register_shutdown_function(function () use ($base) {
             Utils::removeDir($base);
         });
@@ -210,19 +221,29 @@ public function save($zip_filename)
         }
     }
 
+    /**
+     * Make a new Datapackage object that is a copy of the current Datapackage. Bypasses validation.
+     * @return $this
+     * @throws DatapackageValidationFailedException
+     */
+    protected function copy()
+    {
+        return new static($this->descriptor, $this->basePath, true);
+    }
+
     protected $descriptor;
     protected $currentResourcePosition = 0;
     protected $basePath;
     protected $skipValidations = false;
 
-  /**
-   * called by the resources iterator for each iteration.
-   *
-   * @param object $descriptor
-   *
-   * @return \frictionlessdata\datapackage\Resources\BaseResource
-   * @throws \frictionlessdata\datapackage\Exceptions\ResourceValidationFailedException
-   */
+    /**
+     * called by the resources iterator for each iteration.
+     *
+     * @param object $descriptor
+     *
+     * @return \frictionlessdata\datapackage\Resources\BaseResource
+     * @throws \frictionlessdata\datapackage\Exceptions\ResourceValidationFailedException
+     */
     protected function initResource($descriptor)
     {
         return Factory::resource($descriptor, $this->basePath, $this->skipValidations);

src/Resources/BaseResource.php

@@ -75,6 +75,10 @@ public function read($readOptions = null)
         return $rows;
     }
 
+    /**
+     * Loads $this->dataStreams based on $this->path() and $this->data
+     * @return BaseDataStream[]|null
+     */
     public function dataStreams()
     {
         if (is_null($this->dataStreams)) {
@@ -121,6 +125,25 @@ public function path()
         }
     }
 
+    /**
+     * If the resource's $path is local (non-http)
+     * @return bool
+     */
+    public function isLocal()
+    {
+        return !$this->isRemote();
+    }
+
+    /**
+     * If the resource's $path is remote (http)
+     * @return bool
+     */
+    public function isRemote()
+    {
+        $path = $this->path();
+        return Utils::isHttpSource(is_array($path) && count($path) > 0 ? $path[0] : $path);
+    }
+
     public function data()
     {
         return isset($this->descriptor()->data) ? $this->descriptor()->data : null;

tests/DatapackageTest.php

@@ -141,6 +141,37 @@ public function testHttpSource()
         );
     }
 
+    public function testHttpSourceSaveAndLoad()
+    {
+        $package = Mocks\MockFactory::datapackage('mock-http://simple_valid_datapackage_mock_http_data.json');
+
+        $filename = tempnam(sys_get_temp_dir(), 'datapackage-php-tests-').'.zip';
+        //save the datapackage
+        if (is_file($filename)) {
+            unlink($filename);
+        }
+        $package->save($filename);
+
+        //load the new package
+        $package2 = Mocks\MockFactory::datapackage($filename);
+
+        $this->assertDatapackage(
+            (object) [
+                'name' => 'datapackage-name',
+                'resources' => [
+                    (object) [
+                        'name' => 'resource-name',
+                        'path' => ['mock-http://foo.txt', 'mock-http://foo.txt'],
+                    ],
+                ],
+            ],
+            ['resource-name' => ['foo', 'foo']],
+            $package2
+        );
+
+        unlink($filename);
+    }
+
     public function testMultiDataDatapackage()
     {
         $out = [];
@@ -476,6 +507,29 @@ public function testCreateEditDatapackageDescriptor()
         $zip->close();
         unlink($filename);
         $tempdir = $tempdir.DIRECTORY_SEPARATOR;
+
+        //after saving to disk, the paths are updated
+        $expectedDatapackageDescriptor = (object) [
+            'name' => 'my-datapackage-name',
+            'resources' => [
+                (object) [
+                    'name' => 'my-default-resource',
+                    'path' => ["resource-0-data-0", "resource-0-data-1"],
+                ],
+                (object) [
+                    'name' => 'my-renamed-tabular-resource',
+                    'path' => "resource-1.csv",
+                    'profile' => 'tabular-data-resource',
+                    'schema' => (object) [
+                        'fields' => [
+                            (object) ['name' => 'id', 'type' => 'integer'],
+                            (object) ['name' => 'name', 'type' => 'string'],
+                        ],
+                    ],
+                ],
+            ],
+        ];
+
         $this->assertEquals($expectedDatapackageDescriptor, json_decode(file_get_contents($tempdir.'datapackage.json')));
         $this->assertEquals('foo', file_get_contents($tempdir.'resource-0-data-0'));
         $this->assertEquals("testing 改善\n", file_get_contents($tempdir.'resource-0-data-1'));
@@ -484,6 +538,43 @@ public function testCreateEditDatapackageDescriptor()
         Utils::removeDir($tempdir);
     }
 
+    public function testSaveAndLoadZip()
+    {
+        //generate a csv file
+        $csv_filepath = tempnam(sys_get_temp_dir(),'example-csv');
+
+        //create example csv
+        file_put_contents($csv_filepath, "name,email\nJohn Doe,john@example.com");
+
+        //create a new datapackage object
+        $package = Package::create(['name' => 'csv-example','profile' => 'tabular-data-package']);
+
+        //add a csv file
+        $package->addResource('example.csv', [
+            "profile" => "tabular-data-resource",
+            "schema" => ["fields" => [["name" => "name", "type" => "string"],["name" => "email", "type" => "string"]]],
+            "path" => $csv_filepath
+        ]);
+
+        //save the datapackage
+        $filename = tempnam(sys_get_temp_dir(), 'datapackage-php-tests-').'.zip';
+        if (is_file($filename)) {
+            unlink($filename);
+        }
+        $package->save($filename);
+
+        //delete example csv
+        unlink($csv_filepath);
+
+        //load the new package
+        $package2 = Package::load($filename);
+
+        //assert you get expected content back out
+        $this->assertEquals([['name' => 'John Doe', 'email' => 'john@example.com']], $package2->resource('example.csv')->read());
+
+        unlink($filename);
+    }
+
     public function testLoadDatapackageZip()
     {
         $package = Package::load(dirname(__FILE__).'/fixtures/datapackage_zip.zip');
@@ -626,21 +717,21 @@ public function testCsvDialect()
                         'CommitteeTypeDesc' => 'ועדה  משותפת',
                         'Email' => null,
                         'StartDate' => Carbon::__set_state(array(
-                                'date' => '2004-08-12 00:00:00.000000',
-                                'timezone_type' => 3,
-                                'timezone' => 'UTC',
-                            )),
+                            'date' => '2004-08-12 00:00:00.000000',
+                            'timezone_type' => 3,
+                            'timezone' => 'UTC',
+                        )),
                         'FinishDate' => null,
                         'AdditionalTypeID' => null,
                         'AdditionalTypeDesc' => null,
                         'ParentCommitteeID' => null,
                         'CommitteeParentName' => null,
                         'IsCurrent' => true,
                         'LastUpdatedDate' => Carbon::__set_state(array(
-                                'date' => '2015-03-20 12:02:57.000000',
-                                'timezone_type' => 3,
-                                'timezone' => 'UTC',
-                            )),
+                            'date' => '2015-03-20 12:02:57.000000',
+                            'timezone_type' => 3,
+                            'timezone' => 'UTC',
+                        )),
                     ), $row);
                 }
                 ++$rowNum;

tests/Mocks/MockDefaultResource.php

@@ -41,4 +41,17 @@ protected function validateResource()
     {
         return MockResourceValidator::validate($this->descriptor(), $this->basePath);
     }
+
+
+    /**
+     * @inheritDoc
+     * @return bool
+     */
+    public function isRemote()
+    {
+        $path = $this->path();
+        $path_to_check = is_array($path) && count($path) > 0 ? $path[0] : $path;
+        return strpos($path_to_check, 'mock-http://') === 0 || parent::isRemote();
+    }
+
 }