Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Package.RemoveSource #25

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Fixing Package.RemoveSource #25

merged 1 commit into from
Feb 21, 2020

Conversation

danielfireman
Copy link
Collaborator

@danielfireman danielfireman commented Feb 20, 2020 •
edited
Loading

Overview

As noticed by @cschloer the package.RemoveResource was not removing the resource, but removing everything else.

Fix #24

Please preserve this line to notify @danielfireman (lead of this repository)

This change is Reviewable

@danielfireman danielfireman requested a review from roll February 20, 2020 19:42
@coveralls
Copy link

coveralls commented Feb 20, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 82.382% when pulling c2ec875 on fixRemoveResource into 8b21747 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 85.714% when pulling c2ec875 on fixRemoveResource into 8b21747 on master.

roll
roll approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielfireman danielfireman merged commit 05bdddc into master Feb 21, 2020
@danielfireman danielfireman deleted the fixRemoveResource branch February 21, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roll roll roll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package RemoveResource does not work
3 participants
@danielfireman @coveralls @roll