Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools is considered unsafe in a requirements file #12

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

DeanWay
Copy link
Contributor

@DeanWay DeanWay commented Nov 14, 2018

setuptools should only be needed to build this package, not install it.

Having this in requirements.txt is like opening a bakery and telling your customers that in order to buy your bread, they need to have an oven.

see jazzband/pip-tools#522

@DeanWay DeanWay requested a review from murrayrush November 14, 2018 17:12
@DeanWay DeanWay merged commit b8ff4c0 into master Nov 14, 2018
@MatthewSBarnes MatthewSBarnes deleted the remove-setuptools branch November 14, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants