Add stop method for MergeNamed and Merge channels #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ela-kotulska-frequenz
added
the
part:synchronization
github-actions
bot
added
part:core
mathias-baumann-frequenz
suggested changes
Jan 26, 2023
ela-kotulska-frequenz
force-pushed
the
stop_channel
branch
2 times, most recently
from
f58acc4 to
31d9a77
Compare
Both channels stores async tasks that listen on the receivers. If they are removed without stopping the receivers tasks, then user gets error: Task was destroyed but it is pending! `stop` method should be called when channel is no longer needed. Destructor can't be async, so we do that with extra method `stop`. Signed-off-by: ela-kotulska-frequenz <elzbieta.kotulska@frequenz.com>
ela-kotulska-frequenz
force-pushed
the
stop_channel
branch
from
31d9a77 to
dd5d3a7
Compare
shsms
reviewed
Jan 26, 2023
sahas-subramanian-frequenz
changed the title
sahas-subramanian-frequenz
approved these changes
Jan 26, 2023
mathias-baumann-frequenz
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both channels stores async tasks that listen on the receivers. If they are removed without stopping the receivers tasks, then user gets error: Task was destroyed but it is pending!
stopmethod should be called when channel is no longer needed. Destructor can't be async, so we do that with extra methodstop.Signed-off-by: ela-kotulska-frequenz elzbieta.kotulska@frequenz.com