Add a Receiver.triggered method
#328
Conversation
github-actions
bot
added
part:tests
shsms
requested review from
llucax
and removed request for
ela-kotulska-frequenz
|
Other naming options: |
There was a problem hiding this comment.
OK, so the issue we had with TypeGuard as a member method was not it being a member method but about applying the type guard to self, this is why we can't do selected.source(receiver), because we want to narrow selected, not receiver, but when used as a member the variable to narrow is the second argument, not self.
So receiver.is_selected(selected) works and will narrow selected. OK. I don't like the fact that now part of select()is implemented inReceiverunless we have a considerable improvement in how the code is read, andreceiver.is_selected(selected)doesn't read much better thanselected_from(selected, receiver)`.
But maybe something like receiver.is_source_of(selected) could work. What do you think?
shsms
force-pushed
the
selected
branch
2 times, most recently
from
fc7064a to
7005e83
Compare
shsms
changed the title
Receiver.is_selected methodReceiver.matches method
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
This is an alternative for the `selected_from` method and could eventually replace it. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
This is an alternative to the
selected_frommethod.