Document class and module attributes #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tests
daniel-zullo-frequenz
added
the
cmd:skip-release-notes
llucax
reviewed
Sep 15, 2023
daniel-zullo-frequenz
force-pushed
the
fix/amend-documentation
branch
2 times, most recently
from
4020f21 to
1ca6a8f
Compare
llucax
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Not sure why did you remove the limit in the PR. The rest LGTM.
Also, could you not mark conversations I started as resolved? If you do so, I need to go expanding them one by one to see your replies and to remember what comments I made to go see in the code how it was addressed. If you need to keep track of which comments you already addressed, you can use a reaction instead, like 👍 .
Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Add or amend docstrings for all classes and modules where needed. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
daniel-zullo-frequenz
force-pushed
the
fix/amend-documentation
branch
from
e8e92d8 to
17d91b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add or amend docstrings for all classes and modules where needed.
Fixes #31