Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possible values to timer missed_tick_policy parameter documentation #109

Merged
merged 1 commit into from
May 25, 2023
Merged

Add possible values to timer missed_tick_policy parameter documentation #109

merged 1 commit into from
May 25, 2023

Conversation

Marenz
Copy link
Contributor

@Marenz Marenz commented May 24, 2023 •
edited by leandro-lucarella-frequenz
Loading

No description provided.

@Marenz Marenz requested a review from a team as a code owner May 24, 2023 16:22
@github-actions github-actions bot added the part:core Affects the core types (`Sender`, `Receiver`, exceptions, etc.) label May 24, 2023
@Marenz Marenz self-assigned this May 24, 2023
@Marenz Marenz added this to the v0.16.0 milestone May 24, 2023
@leandro-lucarella-frequenz
Copy link
Contributor

Can you please remove the Signed-off-by in the PR description? I know this is GitHub being silly and not removing it automatically, but otherwise it will be included in the merge commit too.

@leandro-lucarella-frequenz
Copy link
Contributor

OK, I removed it for you.

@Marenz
Copy link
Contributor Author

Marenz commented May 25, 2023

Will remove it in future PRs

@Marenz Marenz enabled auto-merge May 25, 2023 08:42
@Marenz
Copy link
Contributor Author

Marenz commented May 25, 2023

Rebased, please re-approve

shsms
shsms previously approved these changes May 25, 2023
View reviewed changes
@Marenz
Copy link
Contributor Author

Marenz commented May 25, 2023

Oh ffs, clicking the rebase button removes the signature

@Marenz Marenz dismissed stale reviews from shsms and leandro-lucarella-frequenz via 4b37bd4 May 25, 2023 08:52
@Marenz
Add possible values to timer missed_tick_policy parameter documentation
a7a51ae 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@github-actions github-actions bot added part:docs Affects the documentation part:synchronization Affects the synchronization of multiple sources (`select`, `merge`) part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels May 25, 2023
@github-actions github-actions bot removed part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:synchronization Affects the synchronization of multiple sources (`select`, `merge`) labels May 25, 2023
@Marenz Marenz added this pull request to the merge queue May 25, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit b9dec35 May 25, 2023
@Marenz Marenz deleted the docudouc branch May 25, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandro-lucarella-frequenz leandro-lucarella-frequenz leandro-lucarella-frequenz approved these changes

@shsms shsms shsms left review comments

@matthias-wende-frequenz matthias-wende-frequenz Awaiting requested review from matthias-wende-frequenz matthias-wende-frequenz was automatically assigned from frequenz-floss/python-sdk-team

Assignees

@Marenz Marenz

Labels
part:core Affects the core types (`Sender`, `Receiver`, exceptions, etc.)
Projects
Python SDK Roadmap
Status: Done
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Marenz @leandro-lucarella-frequenz @shsms