Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Designdoc/batching #90

Merged
merged 12 commits into from
May 20, 2022
Merged

Designdoc/batching #90

merged 12 commits into from
May 20, 2022

Conversation

shannonwells
Copy link
Collaborator

@shannonwells shannonwells commented May 13, 2022 •
edited
Loading

Design document for creating and fetching batches. Closes #10

Also fixed a couple of issues in the delegation design doc.

@shannonwells shannonwells marked this pull request as ready for review May 16, 2022 22:16
aramikm
aramikm reviewed May 16, 2022
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of questions and suggestions!

designdocs/batched_messages.md Show resolved Hide resolved
designdocs/batched_messages.md Outdated Show resolved Hide resolved
designdocs/batched_messages.md Outdated Show resolved Hide resolved
saraswatpuneet
saraswatpuneet approved these changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

wilwade
wilwade reviewed May 17, 2022
View reviewed changes
designdocs/batched_messages.md Outdated Show resolved Hide resolved
designdocs/batched_messages.md Outdated Show resolved Hide resolved
@wilwade
Copy link
Collaborator

wilwade commented May 20, 2022

Options:

  1. No Delegation on chain, you are on your own for inside the batch BatchMessage(signer_has_msa_id)
  2. No delegation on chain, but the schema MUST have msa_id BatchMessage(signer_has_msa_id)
  3. Allow batch message on chain to have a signer and msa_id, but DSNP requires signer == chain's msa_id BatchMessage(signer_has_msa_id ?? msa_id), but DSNP wants ==
  4. Option on schema to force signer == chain's msa_id BatchMessage(signer_has_msa_id == msa_id)

We like 1.

  • Simple
  • Cannot enforce it anyway because batches are off-chain
  • Flexible on the schemas

wilwade
wilwade approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@shannonwells shannonwells enabled auto-merge (squash) May 20, 2022 21:17
@shannonwells shannonwells merged commit 1f112cc into main May 20, 2022
@shannonwells shannonwells deleted the designdoc/batching branch May 20, 2022 21:45
@wilwade wilwade mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramikm aramikm aramikm left review comments

@jvasile jvasile jvasile left review comments

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@enddynayn enddynayn enddynayn approved these changes

@wilwade wilwade wilwade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design Doc] Batched Messages
6 participants
@shannonwells @wilwade @jvasile @enddynayn @aramikm @saraswatpuneet