-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brightness range to display model #788
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
==========================================
+ Coverage 93.73% 94.68% +0.95%
==========================================
Files 6 6
Lines 383 414 +31
Branches 35 24 -11
==========================================
+ Hits 359 392 +33
+ Misses 22 17 -5
- Partials 2 5 +3 ☔ View full report in Codecov by Sentry. |
Should we leave in brightness range as well? |
But I'm not sure what that would represent |
That would represent the min/max (represented as 0-100% in Home Assistant), while the limit limits what can be set at that point in time? |
The limits are already represented by the limits. I am not sure why they return 2 ranges, but the limit seems to be smaller |
I am not following? What is your goal? To redefine the range of the slider in Home Assistant? If that is the case, I think that would be incorrect. Looking at the newer LaMetric model, it will still show the full audio volume range on display, but doesn't allow one to go beyond a certain point. To mimic that behavior, you'd need both? |
Let's have both and have this discussion in the home assistant repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @joostlek 👍
../Frenck
Add brightness range to display model, because when the device is connected to a computer, it won't be able to be put on full brightness. Hence we need to know what the min and max are