Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlight for overdue dates #45

Merged
merged 11 commits into from
Jan 27, 2016
Merged

Syntax Highlight for overdue dates #45

merged 11 commits into from
Jan 27, 2016

Conversation

victal
Copy link
Contributor

@victal victal commented Jan 26, 2016

Adds support for #44 .

From what I tested even on a system without python the plugin continues working fine.

Maybe an option to supress the statup notice could be added if it turned out to be too annoying.

@freitass
Copy link
Owner

@victal this is a nice addition! I liked the message warning the user if his version of vim doesn't support python. However, I don't think the submodule approach to be the best solution. This plugin is supposed to be really simple to install and use. Asking the user (specially those who use plugin managers) to run git submodule update --init might drive them away. Would you consider moving that logic to this project?

@victal
Copy link
Contributor Author

victal commented Jan 27, 2016

Good point. Actually vim-plug did handle the submodule correctly here but I was not sure about other managers, hence the warning.

Updated the PR moving the regex logic inside the plugin and removing the submodule.

freitass added a commit that referenced this pull request Jan 27, 2016
Syntax Highlight for overdue dates
@freitass freitass merged commit e13eb4b into freitass:master Jan 27, 2016
@freitass
Copy link
Owner

Thanks!

dbeniamine added a commit to dbeniamine/todo.txt-vim that referenced this pull request May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants