Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipq40xx-generic: add extreme-networks-ws-ap3915i #3396

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

seilpforte
Copy link

@seilpforte seilpforte commented Dec 17, 2024

  • Must be flashable from vendor firmware
    • Web interface
    • TFTP
    • Other:
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • if there are multiple ports but no WAN port:
        • the PoE input should be WAN, all other ports LAN
        • otherwise the first port should be declared as WAN, all other ports LAN
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Cellular devices only:
    • Added board name to is_cellular_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
    • Added board name with modem setup function setup_ncm_qmi to package/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
  • Docs:
    • Added Device to docs/user/supported_devices.rst

Primary MAC Adress is: ca:b2:ef:60:c6:63
Eth0 MAC is: dc:b8:08:72:a2:ad
Label MAC is: dc:b8:08:72:a2:ad

Keeps forgetting config after any sysupgrade

@github-actions github-actions bot added the 3. topic: hardware Topic: Hardware Support label Dec 17, 2024
@maurerle
Copy link
Member

maurerle commented Dec 17, 2024

This looks like a related thread with a possible solution:
https://forum.openwrt.org/t/ws-ap3915i-settings-lost-upgrading-23-05-0-23-05-2/179770

setting BLOCKSIZE := 64k for the sysupgrades instead..?

also documented in the wiki:

If upgrading an AP3915i from the AP3915i-only OpenWRT image, you will lose configuration!

https://openwrt.org/toh/extreme_networks_ws_ap391x?s[]=ap3915i

Ref: openwrt/openwrt#17305

@blocktrron
Copy link
Member

Primary MAC also needs to be fixed in order to consider merging.

@maurerle
Copy link
Member

Should this be fixed through label-mac in openwrt or through 010-mac-address in gluon?

@blocktrron
Copy link
Member

Preferably this should be fixed in openwrt if possible.

@maurerle
Copy link
Member

maurerle commented Dec 21, 2024

We tried a few things in openwrt:
openwrt/openwrt#17305

We could fix the BLOCKSIZE issue - making sysupgrades keep the config.
However I could not set the label-mac based on the OpenWRT output.

I tried:
label_mac="$(mtd_get_mac_ascii CFG1 ethaddr)" - during the running system, this shows the correct macaddress.
This is also how it was done for the ws-ap3710i
https://github.com/openwrt/openwrt/blob/e321e70ddcd82e0b4a5ad695b83a88d44cde02b4/target/linux/mpc85xx/base-files/etc/board.d/02_network#L21

However it did not work yet.

Snippet:

. /lib/functions.sh
mtd_get_mac_ascii CFG1 ethaddr

I also tried different variants of adding label-mac-device = &eth0; to the dts, which somehow did not exist though.

Eventually this is related to something being broken for ipq40xx (as mentioned in #3389) - so I could need a hint here what to try :)

. /lib/functions.sh
. /lib/functions/system.sh
echo $(get_mac_label)

This snippet shows the correct label, so my assumption that this would change immediatly was just wrong.
With the mentioned PR everything is fine.

So this is blocked waiting on upstream.

@maurerle
Copy link
Member

If main is bumped to the latest openwrt 24.10, this is ready.
The upstream fixes ar merged and backported:
openwrt/openwrt#17305

@rotanid rotanid added the 2. status: blocked Marked as blocked because it's waiting on something label Dec 26, 2024
@rotanid
Copy link
Member

rotanid commented Dec 27, 2024

@maurerle can you please rebase and test again, there seems to be a linter issue

@maurerle
Copy link
Member

Tested again after rebase - fixed the wrong spacing.
Is ready from my side :)

@rotanid rotanid merged commit 828ac80 into freifunk-gluon:main Dec 29, 2024
9 checks passed
@maurerle maurerle deleted the ap3915i branch December 30, 2024 00:37
@Djfe
Copy link
Contributor

Djfe commented Dec 30, 2024

@seilpforte can you update the check list, please? (primary mac and must/keep forget configuration are both working now)

I just want to avoid confusion as this checklist counts as some form of documentation

@maurerle
Copy link
Member

More important, we forgot to add it to the supported devices list :(

@rotanid rotanid removed the 2. status: blocked Marked as blocked because it's waiting on something label Dec 31, 2024
@rotanid
Copy link
Member

rotanid commented Dec 31, 2024

i edited the checklist. can't do the supported devices atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: hardware Topic: Hardware Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants