libgluonutil: add missing libgen import #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import of libgen.h required for basename() was missing. This lead to undesired behavior on 64 bit systems, where only the upper 32-bit of the returned pointer was used. On ARM64 systems such as mediatek-filogic, this lead to a signed extend of the 32-bit address, leading to a crash of respondd. Signed-off-by: David Bauer <mail@david-bauer.net>
|
Note to backport this to v2023.2.x. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
The import of libgen.h required for basename() was missing. This lead to undesired behavior on 64 bit systems, where only the upper 32-bit of the returned pointer was used. On ARM64 systems such as mediatek-filogic, this lead to a signed extend of the 32-bit address, leading to a crash of respondd. Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit 3654f83)
|
Successfully created backport PR for |
|
Git push to origin failed for v2023.2.x with exitcode 1 |
blocktrron
added a commit
that referenced
this pull request
Dec 19, 2024
The import of libgen.h required for basename() was missing. This lead to undesired behavior on 64 bit systems, where only the upper 32-bit of the returned pointer was used. On ARM64 systems such as mediatek-filogic, this lead to a signed extend of the 32-bit address, leading to a crash of respondd. Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit 3654f83) Co-authored-by: David Bauer <mail@david-bauer.net>
RolandoMagico
pushed a commit
to RolandoMagico/gluon
that referenced
this pull request
Dec 25, 2024
The import of libgen.h required for basename() was missing. This lead to undesired behavior on 64 bit systems, where only the upper 32-bit of the returned pointer was used. On ARM64 systems such as mediatek-filogic, this lead to a signed extend of the 32-bit address, leading to a crash of respondd. Signed-off-by: David Bauer <mail@david-bauer.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import of libgen.h required for basename() was missing. This lead to undesired behavior on 64 bit systems, where only the upper 32-bit of the returned pointer was used.
On ARM64 systems such as mediatek-filogic, this lead to a signed extend of the 32-bit address, leading to a crash of respondd.