Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gluon-mesh-batman-adv: add "gateway_tq" field to respondd statistics #2596

Merged

Conversation

lemoer
Copy link
Member

@lemoer lemoer commented Aug 6, 2022

This new field reflects the TQ to the selected gateway.

Before this commit, if you had connectivity issues in a larger mesh,
it was a tedious task to understand which nodes are affected and which
are not. By providing this new value for each node, it becomes easier
to see which nodes are affected by the connectivity issues and which
are not.

The new field "gateway_tq" is located at the toplevel of the
statistics resource (next to "gateway" and "gateway_nexthop"):

gluon-neighbour-info -d ::1 -r statistics
{
    ...
    "gateway": "02:a1:71:04:09:10",
    "gateway_nexthop": "88:e6:40:20:90:10",
    "gateway_tq": 193,
    ...
}

Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message contains a mistake:

The new field "gateway_nexthop"

Should be The new field "gateway_tq"

Rest looks correct.

This new field reflects the TQ to the selected gateway.

Before this commit, if you had connectivity issues in a larger mesh,
it was a tedious task to understand which nodes are affected and which
are not. By providing this new value for each node, it becomes easier
to see which nodes are affected by the connectivity issues and which
are not.

The new field "gateway_tq" is located at the toplevel of the
statistics resource (next to "gateway" and "gateway_nexthop"):

    gluon-neighbour-info -d ::1 -r statistics
    {
        ...
        "gateway": "02:a1:71:04:09:10",
        "gateway_nexthop": "88:e6:40:20:90:10",
        "gateway_tq": 193,
        ...
    }
@lemoer lemoer force-pushed the pr_batman_respondd_addition_1 branch from 6951190 to 01f606f Compare August 7, 2022 08:20
@lemoer
Copy link
Member Author

lemoer commented Aug 9, 2022

This is tested.

@blocktrron blocktrron merged commit 6df0647 into freifunk-gluon:master Aug 9, 2022
lemoer added a commit to lemoer/gluon that referenced this pull request Oct 31, 2022
The gateway_tq was added to respondd in freifunk-gluon#2596. Now, we also show it on
the status page.
lemoer added a commit to lemoer/gluon that referenced this pull request Dec 15, 2022
The gateway_tq was added to respondd in freifunk-gluon#2596. Now, we also show it on
the status page.
JayBraker pushed a commit to JayBraker/gluon that referenced this pull request Apr 12, 2023
…reifunk-gluon#2596)

This new field reflects the TQ to the selected gateway.

Before this commit, if you had connectivity issues in a larger mesh,
it was a tedious task to understand which nodes are affected and which
are not. By providing this new value for each node, it becomes easier
to see which nodes are affected by the connectivity issues and which
are not.

The new field "gateway_tq" is located at the toplevel of the
statistics resource (next to "gateway" and "gateway_nexthop"):

    gluon-neighbour-info -d ::1 -r statistics
    {
        ...
        "gateway": "02:a1:71:04:09:10",
        "gateway_nexthop": "88:e6:40:20:90:10",
        "gateway_tq": 193,
        ...
    }
JayBraker pushed a commit to JayBraker/gluon that referenced this pull request Apr 12, 2023
The gateway_tq was added to respondd in freifunk-gluon#2596. Now, we also show it on
the status page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants