gluon-core: disable legacy_rates by default, drop support for support… #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
commented
Apr 28, 2019
| @@ -27,28 +27,31 @@ need_string_array({'ntp_servers'}, false) | |||
|
|
|||
| need_string_match(in_domain({'prefix6'}), '^[%x:]+/64$') | |||
|
|
|||
|
|
|||
| local supported_rates = {6000, 9000, 12000, 18000, 24000, 36000, 48000, 54000} | |||
There was a problem hiding this comment.
This is used to validate mcast_rate entries, I've removed all 802.11b rates here.
|
Do we even need a site.conf option for this? I'd prefer to just hardcode disabling legacy rates. |
|
Agreed, dropped. |
mweinelt
added
2. status: blocked
…ed and basic rates
10 tasks
blocktrron
pushed a commit
to blocktrron/gluon
that referenced
this pull request
May 13, 2019
…ed and basic rates (freifunk-gluon#1716)
omniuwo
pushed a commit
to pjodd/gluon-site
that referenced
this pull request
May 30, 2019
ghost
mentioned this pull request
blocktrron
pushed a commit
to blocktrron/gluon
that referenced
this pull request
Jun 18, 2019
…ed and basic rates (freifunk-gluon#1716)
mmalte
added a commit
to ffac/site
that referenced
this pull request
Sep 29, 2019
802.11b ist now disabled by default: freifunk-gluon/gluon#1716 HT20 is now default and no longer configurable: freifunk-gluon/gluon@3ddcf50
mmalte
added a commit
to ffac/site
that referenced
this pull request
Nov 20, 2019
802.11b ist now disabled by default: freifunk-gluon/gluon#1716 HT20 is now default and no longer configurable: freifunk-gluon/gluon@3ddcf50
T-X
added a commit
to T-X/site-ffhl
that referenced
this pull request
Jan 25, 2020
802.11b support and therefore these two settings were removed with Gluon v2019.1: freifunk-gluon/gluon#1716 https://gluon.readthedocs.io/en/v2019.1.x/releases/v2019.1.html#site-conf
T-X
added a commit
to T-X/site-ffhl
that referenced
this pull request
Jan 26, 2020
802.11b support and therefore these two settings were removed with Gluon v2019.1: freifunk-gluon/gluon#1716 https://gluon.readthedocs.io/en/v2019.1.x/releases/v2019.1.html#site-conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed and basic rates
All we ever wanted to achieve with supported and basic rates was disabling 802.11b. In the meantime OpenWrt provides¹ the
legacy_ratesoption to accomplish exactly that. This obsoletes the need for configurable basic and supported rates, as neither 802.11a nor 802.11g are considered as harmful as 802.11b. Their "slowness" will instead be mitigated through airtime fairness in a future release.This patchset makes use of the obsoletion check feature in #1702.
[1] openwrt/openwrt@ed62d91