[RFC] gluon-status-page: update memory usage estimation #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Even if it's only two two-line changes, please split this into two commits, as the respondd change is already useful by itself. |
Let gluon-respondd expose "MemAvailable" from /proc/meminfo to allow for a more realistic memory-usage estimation. Information on MemAvailable can be found here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ commit/?id=34e431b0ae398fc54ea69ff85ec700722c9da773
blocktrron
force-pushed
the
pr-memory-calculation
branch
from
cbc6e3b to
02dfc66
Compare
|
Pull-Request updated |
christf
approved these changes
Aug 24, 2018
skorpy2009
approved these changes
Aug 24, 2018
skorpy2009
added a commit
to skorpy2009/yanic
that referenced
this pull request
Aug 24, 2018
Fix memory usage estimation following this commit: freifunk-gluon/gluon#1517
skorpy2009
added a commit
to skorpy2009/yanic
that referenced
this pull request
Aug 25, 2018
Fix memory usage estimation following this commit: freifunk-gluon/gluon#1517
skorpy2009
added a commit
to skorpy2009/yanic
that referenced
this pull request
Aug 25, 2018
Fix memory usage estimation following this commit: freifunk-gluon/gluon#1517
skorpy2009
added a commit
to skorpy2009/yanic
that referenced
this pull request
Aug 25, 2018
Fix memory usage estimation following this commit: freifunk-gluon/gluon#1517
skorpy2009
added a commit
to skorpy2009/yanic
that referenced
this pull request
Aug 25, 2018
Fix memory usage estimation following this commit: freifunk-gluon/gluon#1517
skorpy2009
added a commit
to skorpy2009/yanic
that referenced
this pull request
Aug 25, 2018
Fix memory usage estimation following this commit: freifunk-gluon/gluon#1517
skorpy2009
added a commit
to skorpy2009/yanic
that referenced
this pull request
Aug 25, 2018
Fix memory usage estimation following this commit: freifunk-gluon/gluon#1517
genofire
pushed a commit
to FreifunkBremen/yanic
that referenced
this pull request
Aug 30, 2018
Fix memory usage estimation following this commit: freifunk-gluon/gluon#1517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way gluon estimates memory-usage on the status-page. Currently memory consumption in percent gets calculated using
This commit (torvalds/linux@34e431b) suggests that this might not the best way to calculate such an estimation.
TL-MR3020 v1
Old:
1-((4508+1940+4108)/27368) = 61.42%New:
1-(8368/27368) = 69.42%TL-WR1043 v3
Old:
1-((29280+2672+4108)/60000) = 39.90%New:
1-(23388/60000) = 61.02%As those results are not all small differences but somewhat drastic differences (and I'm lacking in-depth knowledge about memory-management) I'm not sure which way better reflects true memory availability.