Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipq40xx - DSA migration process #2666

Open
18 of 20 tasks
AiyionPrime opened this issue Oct 11, 2022 · 21 comments
Open
18 of 20 tasks

ipq40xx - DSA migration process #2666

AiyionPrime opened this issue Oct 11, 2022 · 21 comments
Labels
2. status: waiting-on-upstream Waiting for upstream changes 3. topic: hardware Topic: Hardware Support 9. meta: upstream issue Issue pertains to an upstream project

Comments

@AiyionPrime
Copy link
Member

AiyionPrime commented Oct 11, 2022

Similar, yet incomparably simpler than #2413 this is tracking the DSA migration following openwrt/openwrt#4721 and related patches.

The workflow would be: find your model, make sure it has DSA support in OpenWrt report back whether it is done or not, needs changes or has no support in OpenWrt and should therefore be dropped.

missing DSA setup

  • engenius-ens620ext
  • zyxel-wre6606

done

  • 8devices-jalapeno
  • aruba-ap-303 (aruba-instant-on-ap11)
  • aruba-ap-303h (aruba-instant-on-ap11d)
  • aruba-ap-365 (aruba_ap-365)
  • avm-fritz-box-4040
  • avm-fritz-box-7530
  • avm-fritz-repeater-1200
  • gl.inet-gl-ap1300
  • gl.inet-gl-b1300
  • linksys-ea6350v3
  • mikrotik-sxtsq-5-ac-rbsxtsqg-5acd (mikrotik-discg-5acd)
  • netgear-ex6100v2
  • netgear-ex6150v2
  • openmesh-a42
  • openmesh-a62
  • plasma-cloud-pa1200
  • plasma-cloud-pa2200
  • zyxel-nbg6617
@rotanid rotanid added 3. topic: hardware Topic: Hardware Support 9. meta: upstream issue Issue pertains to an upstream project 2. status: waiting-on-upstream Waiting for upstream changes labels Oct 11, 2022
@blocktrron
Copy link
Member

@AiyionPrime I think the AP-303 as well as 4040 are already migrated? A full re-validation is not necessary downstream, as it is performed upstream. We also didn't do it for neither mt7621 nor xrx200

@herbetom
Copy link
Contributor

Not yet migrated devices were disabled in openwrt/openwrt@db19efe.

The following are currently also done:

  • avm-fritz-box-7530
  • avm-fritz-repeater-1200
  • gl.inet-gl-b1300
  • linksys-ea6350v3
  • zyxel-nbg6617
  • 8devices-jalapeno
  • mikrotik-sxtsq-5-ac-rbsxtsqg-5acd (mikrotik-discg-5acd)

Figuring out wheter the devies were migrated is as easy as locking at the file and checking if they are still commented out with a # Missing DSA Setup comment: target/linux/ipq40xx/image/generic.mk

@ecsv
Copy link
Contributor

ecsv commented Oct 30, 2022

@AiyionPrime
Copy link
Member Author

I've got a notifier to monitor these changes in that part of openwrt's tree; once they make it to master, I'll mark them as done.

@AiyionPrime
Copy link
Member Author

updated the tracker, thanks @ecsv!

@AiyionPrime
Copy link
Member Author

AiyionPrime commented Nov 14, 2022

@rotanid
Copy link
Member

rotanid commented Dec 4, 2022

i do own some netgear-ex6150v2, but i'm not sure i can help. maybe @mbaumga ?

@AiyionPrime
Copy link
Member Author

AiyionPrime commented Dec 28, 2022

@JJWatMyself
Copy link

Aruba ap-303h tests are good and have reported this on the other thread a few minutes ago. There are two items I have identified to address in the future, but not specific to DSA.

I also flagged an invisible font/font color issue on the default theme, but will likely need to log a bug somewhere.

@JJWatMyself
Copy link

Ok, DSA for Aruba AP-303H is live in the snapshot and I have verified. I am running dumb AP with many VLANs and wired ports configured to do VLANs also.

openwrt/openwrt#11579 (comment)

image

@Djfe
Copy link
Contributor

Djfe commented Feb 6, 2023

I'm going to fix this upstream for the zyxel-wre6606
Maybe also for the netgear-ex6150v2

@Djfe
Copy link
Contributor

Djfe commented Feb 24, 2023

I kinda stopped after the Zyxel didn't want to boot anymore (after me flashing master with the changes) and I wasn't able to interrupt boot anymore since then.
I'll try to get around to it this weekend but start with the EX6150v2 since it's easy to recover.

@steveglennon
Copy link

steveglennon commented Feb 24, 2023 via email

@AiyionPrime
Copy link
Member Author

@blocktrron committed openwrt/openwrt@bf055fc

So 6100v2 and 6150v2 are done.

@skorpy2009
Copy link
Member

@AiyionPrime @blocktrron
What do I have to do:

https://github.com/openwrt/openwrt/commit/4b280ad91a6b155ac71c417aaa7bb5f4e328712f @skorpy2009 ZyXEL WRE6606

    https://github.com/openwrt/openwrt/blob/master/target/linux/ipq40xx/image/generic.mk#L1194-L1195

@Djfe
Copy link
Contributor

Djfe commented Apr 11, 2023

test this Djfe/openwrt@9c2353c
I need to recover my device still, else I would have already done a PR. (I only did swport5 and it didn't boot anymore..)
One of the swports (switch ports) will come up as an interface, that's the one we need to keep then.

@Djfe
Copy link
Contributor

Djfe commented Apr 28, 2023

Update on my part:
I finally figured out what broke my Zyxel wre6606
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=45eb57f12f3a128a1822a20b7e536527ab92ca67
The kernel got too large and the bootloader doesn't load it fully.
I might've to increase the compat version so people don't accidentally brick their device by upgrading without adjusting bootcmd first.

Apart from that I still have that pesty issue that the wre6606 isn't reacting to any of my keyboard inputs.
While connecting tx to rx on my ttl directly with a cable works just fine.
I tested with screen, picocom and gtkterm.

Other devices I used my ttl adapter with so far didn't receive my tx either.
Next test: using an openwrt Router with ssh as my ttl Adapter.

@mkg20001
Copy link
Member

I tested hap ac2 (ipq40xx-mikrotik) as it gained dsa aswell. It has an increased compat version so I had to manually increment it in uci system compat_version to install the upgrade. Everything came up after upgrading. No new problems yet.

@Djfe
Copy link
Contributor

Djfe commented May 21, 2023

did you test openwrt or gluon?

@mkg20001
Copy link
Member

gluon, but installed image via sysupgrade and built from next branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: waiting-on-upstream Waiting for upstream changes 3. topic: hardware Topic: Hardware Support 9. meta: upstream issue Issue pertains to an upstream project
Projects
None yet
Development

No branches or pull requests

10 participants